Skip to content

Commit

Permalink
Rename servicename to kerberosServiceName
Browse files Browse the repository at this point in the history
Signed-off-by: Arun Yogesh <6723526+ArunYogesh@users.noreply.github.com>
  • Loading branch information
ArunYogesh committed Mar 1, 2024
1 parent 9fddd28 commit b1da4a8
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions pkg/scalers/kafka_scaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ type kafkaMetadata struct {
password string

// GSSAPI
keytabPath string
realm string
kerberosConfigPath string
serviceName string
keytabPath string
realm string
kerberosConfigPath string
kerberosServiceName string

// OAUTHBEARER
scopes []string
Expand Down Expand Up @@ -292,8 +292,8 @@ func parseKerberosParams(config *scalersconfig.ScalerConfig, meta *kafkaMetadata
}
meta.kerberosConfigPath = path

if config.AuthParams["serviceName"] != "" {
meta.serviceName = strings.TrimSpace(config.AuthParams["serviceName"])
if config.AuthParams["kerberosServiceName"] != "" {
meta.kerberosServiceName = strings.TrimSpace(config.AuthParams["kerberosServiceName"])
}

meta.saslType = mode
Expand Down Expand Up @@ -546,8 +546,8 @@ func getKafkaClients(metadata kafkaMetadata) (sarama.Client, sarama.ClusterAdmin
if metadata.saslType == KafkaSASLTypeGSSAPI {
config.Net.SASL.Enable = true
config.Net.SASL.Mechanism = sarama.SASLTypeGSSAPI
if metadata.serviceName != "" {
config.Net.SASL.GSSAPI.ServiceName = metadata.serviceName
if metadata.kerberosServiceName != "" {
config.Net.SASL.GSSAPI.ServiceName = metadata.kerberosServiceName
} else {
config.Net.SASL.GSSAPI.ServiceName = "kafka"
}
Expand Down

0 comments on commit b1da4a8

Please sign in to comment.