Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to sigs.k8s.io/controller-runtime@v0.15.0 #4581

Closed
prometherion opened this issue May 29, 2023 · 3 comments · Fixed by #4582
Closed

Update to sigs.k8s.io/controller-runtime@v0.15.0 #4581

prometherion opened this issue May 29, 2023 · 3 comments · Fixed by #4582
Assignees
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@prometherion
Copy link
Contributor

Proposal

At the current state (1179eaa) the controller-runtime dependency is pinned to v0.15.0-alpha.0.

Last week, the latest stable release of controller-runtime was officially released as v0.15.0.

Some breaking changes have been introduced, such as the webhook.Validator interface: as a developer who is importing the keda code-base, and who has built its own operator based on v0.15.0, I'm blocked due to mismatching signature.

# github.com/kedacore/keda/v2/apis/keda/v1alpha1
../../../go/pkg/mod/github.com/kedacore/keda/v2@v2.10.1/apis/keda/v1alpha1/scaledobject_webhook.go:53:27: cannot use &ScaledObject{} (value of type *ScaledObject) as type admission.Validator in variable declaration:
	*ScaledObject does not implement admission.Validator (wrong type for ValidateCreate method)
		have ValidateCreate() error
		want ValidateCreate() (warnings admission.Warnings, err error)

Use-Case

By developing an Operator with controller-runtime@v0.15.0 I should be able to import the keda code base without any downside.

Is this a feature you are interested in implementing yourself?

Maybe

Anything else?

No response

@prometherion prometherion added feature-request All issues for new features that have not been committed to needs-discussion labels May 29, 2023
@JorTurFer
Copy link
Member

Hi,
This makes sense totally, and it was in my TODOs indeed. Are you willing to bump it from your side and open a PR?

@prometherion
Copy link
Contributor Author

@JorTurFer I can try to contribute, sure thing!

@JorTurFer
Copy link
Member

I assign the issue to you 🙇
If you have any trouble with this, please let us know how we could help 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Status: Ready To Ship
Development

Successfully merging a pull request may close this issue.

2 participants