You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the current state (1179eaa) the controller-runtime dependency is pinned to v0.15.0-alpha.0.
Last week, the latest stable release of controller-runtime was officially released as v0.15.0.
Some breaking changes have been introduced, such as the webhook.Validator interface: as a developer who is importing the keda code-base, and who has built its own operator based on v0.15.0, I'm blocked due to mismatching signature.
# github.com/kedacore/keda/v2/apis/keda/v1alpha1
../../../go/pkg/mod/github.com/kedacore/keda/v2@v2.10.1/apis/keda/v1alpha1/scaledobject_webhook.go:53:27: cannot use &ScaledObject{} (value of type *ScaledObject) as type admission.Validator in variable declaration:
*ScaledObject does not implement admission.Validator (wrong type for ValidateCreate method)
have ValidateCreate() error
want ValidateCreate() (warnings admission.Warnings, err error)
Use-Case
By developing an Operator with controller-runtime@v0.15.0 I should be able to import the keda code base without any downside.
Is this a feature you are interested in implementing yourself?
Maybe
Anything else?
No response
The text was updated successfully, but these errors were encountered:
Proposal
At the current state (1179eaa) the
controller-runtime
dependency is pinned tov0.15.0-alpha.0
.Last week, the latest stable release of
controller-runtime
was officially released as v0.15.0.Some breaking changes have been introduced, such as the
webhook.Validator
interface: as a developer who is importing thekeda
code-base, and who has built its own operator based on v0.15.0, I'm blocked due to mismatching signature.Use-Case
By developing an Operator with
controller-runtime@v0.15.0
I should be able to import thekeda
code base without any downside.Is this a feature you are interested in implementing yourself?
Maybe
Anything else?
No response
The text was updated successfully, but these errors were encountered: