Bumping up controller-runtime@v0.15.0 #4582

prometherion · 2023-05-29T11:47:12Z

Bumping up the kubernetes-sigs/controller-runtime dependency to v0.15.0

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Changelog has been updated and is aligned with our changelog requirements
Commits are signed with Developer Certificate of Origin (DCO - learn more)

JorTurFer

Thanks for the improvement, could you update the changelog too?
I think that this improvement could be placed in Other section

cmd/operator/main.go

JorTurFer · 2023-05-29T12:31:07Z

There are some build errors, could you check them? https://github.com/kedacore/keda/actions/runs/5111676017/jobs/9188904903?pr=4582

cmd/webhooks/main.go

pkg/util/tls_config.go

cmd/adapter/main.go

zroubalik · 2023-05-31T08:34:51Z

/run-e2e
Update: You can check the progress here

prometherion · 2023-05-31T10:12:46Z

@zroubalik may I ask you for some help understanding the root cause of the failed e2e tests? 🤔

zroubalik · 2023-05-31T11:14:25Z

@zroubalik may I ask you for some help understanding the root cause of the failed e2e tests? 🤔

seems like some unrelate env problem, let me re-trigger

zroubalik · 2023-05-31T11:14:52Z

/run-e2e
Update: You can check the progress here

JorTurFer · 2023-05-31T11:42:47Z

looks like a consistent error, let me check it

JorTurFer · 2023-05-31T11:47:20Z

I can reproduce it locally:

The CustomResourceDefinition "scaledjobs.keda.sh" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

There are some missing changes in manifests too, could you run make manifests and commit the changes?

zroubalik · 2023-05-31T12:08:39Z

I can reproduce it locally:
The CustomResourceDefinition "scaledjobs.keda.sh" is invalid: metadata.annotations: Too long: must have at most 262144 bytes
There are some missing changes in manifests too, could you run make manifests and commit the changes?

good catch, yeah please regenerate and we can give it another try

prometherion · 2023-05-31T12:36:29Z

good catch, yeah please regenerate and we can give it another try

Done, it would be good having a sort of automation to ensure the generated files are correctly committed.

JorTurFer · 2023-05-31T13:02:52Z

Done, it would be good having a sort of automation to ensure the generated files are correctly committed.

You're totally right! We have already commented it internally after noticing it 😄

pkg/util/tls_config.go

zroubalik · 2023-06-01T14:27:34Z

/run-e2e
Update: You can check the progress here

zroubalik · 2023-06-01T16:18:14Z

/run-e2e
Update: You can check the progress here

CHANGELOG.md

zroubalik · 2023-06-01T19:41:52Z

/run-e2e azure
Update: You can check the progress here

Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>

zroubalik

please fix the typo, I'll rerun the e2e tests and we are good to go. Thanks!

CHANGELOG.md

Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>

zroubalik · 2023-06-05T09:31:36Z

/run-e2e
Update: You can check the progress here

zroubalik

LGTM, great job, thanks!

zroubalik · 2023-06-05T12:04:10Z

/run-e2e selenium
Update: You can check the progress here

prometherion requested a review from a team as a code owner May 29, 2023 11:47

JorTurFer reviewed May 29, 2023

View reviewed changes

prometherion force-pushed the issues/4581 branch from 16a6cbf to 08c6c63 Compare May 29, 2023 12:04

prometherion requested a review from JorTurFer May 29, 2023 12:19

JorTurFer reviewed May 29, 2023

View reviewed changes

cmd/operator/main.go Outdated Show resolved Hide resolved

prometherion force-pushed the issues/4581 branch from 08c6c63 to e960226 Compare May 29, 2023 12:58

zroubalik reviewed May 29, 2023

View reviewed changes

cmd/webhooks/main.go Outdated Show resolved Hide resolved

prometherion force-pushed the issues/4581 branch 3 times, most recently from 17d55e9 to e70fd67 Compare May 30, 2023 12:40

JorTurFer reviewed May 30, 2023

View reviewed changes

pkg/util/tls_config.go Outdated Show resolved Hide resolved

prometherion force-pushed the issues/4581 branch from e70fd67 to 0cf82a2 Compare May 31, 2023 06:27

prometherion requested review from JorTurFer and zroubalik May 31, 2023 08:04

zroubalik reviewed May 31, 2023

View reviewed changes

cmd/adapter/main.go Outdated Show resolved Hide resolved

prometherion force-pushed the issues/4581 branch 3 times, most recently from 7c536f8 to c65601e Compare May 31, 2023 08:31

prometherion force-pushed the issues/4581 branch from d587b29 to c8ee43c Compare May 31, 2023 12:36

prometherion force-pushed the issues/4581 branch from c8ee43c to 78e6802 Compare May 31, 2023 14:03

prometherion force-pushed the issues/4581 branch from 78e6802 to 1ea09a1 Compare June 1, 2023 07:54

JorTurFer reviewed Jun 1, 2023

View reviewed changes

pkg/util/tls_config.go Outdated Show resolved Hide resolved

prometherion force-pushed the issues/4581 branch 2 times, most recently from b8a35ba to f47ea5f Compare June 1, 2023 09:04

prometherion force-pushed the issues/4581 branch from f47ea5f to dcd925e Compare June 1, 2023 16:15

JorTurFer reviewed Jun 1, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

prometherion force-pushed the issues/4581 branch from dcd925e to 2e13502 Compare June 5, 2023 08:46

prometherion added 4 commits June 5, 2023 10:48

feat(go.mod): updating sigs.k8s.io/controller-runtime@v0.15.0

5d60fc7

Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>

refactor: aligning to kubernetes-sigs/controller-runtime@v0.1.50

eeab642

Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>

refactor(util): parsing TLS min version as string

e146830

Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>

refactor(tls): tls min version from environment variable

bf55952

Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>

prometherion force-pushed the issues/4581 branch from 2e13502 to 8ac5cc1 Compare June 5, 2023 08:48

zroubalik reviewed Jun 5, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

prometherion added 2 commits June 5, 2023 11:27

refactor(webhooks)!: removing tls-min-version flag

43c312f

Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>

chore(manifests): aligning to kubernetes-sigs/controller-runtime@v0.1.50

e727d41

Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>

prometherion force-pushed the issues/4581 branch from 8ac5cc1 to e727d41 Compare June 5, 2023 09:27

prometherion requested a review from zroubalik June 5, 2023 09:27

zroubalik approved these changes Jun 5, 2023

View reviewed changes

zroubalik enabled auto-merge (squash) June 5, 2023 09:32

zroubalik merged commit 21a6d6e into kedacore:main Jun 5, 2023
21 checks passed

prometherion deleted the issues/4581 branch June 5, 2023 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bumping up controller-runtime@v0.15.0 #4582

Bumping up controller-runtime@v0.15.0 #4582

prometherion commented May 29, 2023 •

edited by JorTurFer

JorTurFer left a comment

JorTurFer commented May 29, 2023

zroubalik commented May 31, 2023 •

edited by github-actions bot

prometherion commented May 31, 2023

zroubalik commented May 31, 2023

zroubalik commented May 31, 2023 •

edited by github-actions bot

JorTurFer commented May 31, 2023

JorTurFer commented May 31, 2023 •

edited

zroubalik commented May 31, 2023

prometherion commented May 31, 2023

JorTurFer commented May 31, 2023

zroubalik commented Jun 1, 2023 •

edited by github-actions bot

zroubalik commented Jun 1, 2023 •

edited by github-actions bot

zroubalik commented Jun 1, 2023 •

edited by github-actions bot

zroubalik left a comment

zroubalik commented Jun 5, 2023 •

edited by github-actions bot

zroubalik left a comment

zroubalik commented Jun 5, 2023 •

edited by github-actions bot

Bumping up controller-runtime@v0.15.0 #4582

Bumping up controller-runtime@v0.15.0 #4582

Conversation

prometherion commented May 29, 2023 • edited by JorTurFer

Checklist

JorTurFer left a comment

Choose a reason for hiding this comment

JorTurFer commented May 29, 2023

zroubalik commented May 31, 2023 • edited by github-actions bot

prometherion commented May 31, 2023

zroubalik commented May 31, 2023

zroubalik commented May 31, 2023 • edited by github-actions bot

JorTurFer commented May 31, 2023

JorTurFer commented May 31, 2023 • edited

zroubalik commented May 31, 2023

prometherion commented May 31, 2023

JorTurFer commented May 31, 2023

zroubalik commented Jun 1, 2023 • edited by github-actions bot

zroubalik commented Jun 1, 2023 • edited by github-actions bot

zroubalik commented Jun 1, 2023 • edited by github-actions bot

zroubalik left a comment

Choose a reason for hiding this comment

zroubalik commented Jun 5, 2023 • edited by github-actions bot

zroubalik left a comment

Choose a reason for hiding this comment

zroubalik commented Jun 5, 2023 • edited by github-actions bot

prometherion commented May 29, 2023 •

edited by JorTurFer

zroubalik commented May 31, 2023 •

edited by github-actions bot

zroubalik commented May 31, 2023 •

edited by github-actions bot

JorTurFer commented May 31, 2023 •

edited

zroubalik commented Jun 1, 2023 •

edited by github-actions bot

zroubalik commented Jun 1, 2023 •

edited by github-actions bot

zroubalik commented Jun 1, 2023 •

edited by github-actions bot

zroubalik commented Jun 5, 2023 •

edited by github-actions bot

zroubalik commented Jun 5, 2023 •

edited by github-actions bot