Deprecation cleanup for 2.12 release

[dttung2905]

Hi team,
I create this issue to track the deprecation clean up for 2.12 release. Included in this clean up are the following issues: ( may be more than one )

• Remove deprecated field metricName from Scalers. #4240

[lefterisALEX]

Is that removed from all scalers? Was testing 2.12.0 version with the following scaled object and still works.

apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  name: "sample-scaled-object"
spec:
  pollingInterval: 30
  minReplicaCount: 2
  maxReplicaCount: 10
 
  scaleTargetRef:
    name: "swiss-knife"
 
  triggers:
    - type: prometheus
      metadata:
        serverAddress: http://kube-prometheus-stack-thanos-query-frontend.kube-system:9090/
        metricName: nginx_ingress_controller_requests
        query: |
          sum(
              rate(
                  nginx_ingress_controller_requests{
                      exported_namespace="kube-system",
                      exported_service="hubble-ui",
                  }[2m]
              )
          )

        threshold: "1"
       ```

[zroubalik]

The ScaledObject will work, but the property is not used anymore.

[lefterisALEX]

thanks for the quick response, that means the line with the metricName do not any difference if we have it or not?

[zroubalik]

Yes, if you want to assigne name to this trigger, use trigger.name.

[lefterisALEX]

maybe i am not aware about it , but how this can be a breaking change? Might be that the value of the metricName be used for something else and by removing it this will break?