Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulsar Scaler OAuth support audience #5069

Closed
qizichao-dm opened this issue Oct 11, 2023 · 2 comments · Fixed by #5073 or kedacore/keda-docs#1243
Closed

Pulsar Scaler OAuth support audience #5069

qizichao-dm opened this issue Oct 11, 2023 · 2 comments · Fixed by #5073 or kedacore/keda-docs#1243
Assignees
@qizichao-dm
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@qizichao-dm
Copy link
Contributor

qizichao-dm commented Oct 11, 2023 •
edited

Proposal

Audience could not be specified in current Pulsar Scaler OAuth Config. Though audience is not a part of the OAuth 2.0 spec, it's usually needed and mentioned in pulsar document

Use-Case

Use the Pulsar Scaler with a Pulsar instance and OAuth.

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response
@qizichao-dm qizichao-dm added feature-request All issues for new features that have not been committed to needs-discussion labels Oct 11, 2023
@zroubalik
Copy link
Member

@qizichao-dm seems reasonable, should I assing the issue to you? :)

@qizichao-dm qizichao-dm mentioned this issue Oct 12, 2023
Merged
7 tasks
@qizichao-dm
Copy link
Contributor Author

qizichao-dm commented Oct 12, 2023 •
edited

@qizichao-dm seems reasonable, should I assing the issue to you? :)

Sure. I've made PRs ready for review
#5073
kedacore/keda-docs#1243

@qizichao-dm qizichao-dm mentioned this issue Oct 12, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qizichao-dm qizichao-dm

Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Status: Done
Milestone
No milestone
2 participants
@zroubalik @qizichao-dm