Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support endpointParams in pulsar oauth #5073

Merged
merged 3 commits into from Oct 13, 2023

Conversation

qizichao-dm
Copy link
Contributor

@qizichao-dm qizichao-dm commented Oct 12, 2023

Support endpointParams in pulsar oauth and parameters including audience could be set after this PR.

Checklist

Fixes #5069

Relates to kedacore/keda-docs#1243

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@qizichao-dm qizichao-dm force-pushed the pulsar_oauth branch 2 times, most recently from 1fb593a to e1aa3c8 Compare October 12, 2023 03:01
Signed-off-by: Zichao Qi <qizichao@deepmirror.com>
@qizichao-dm qizichao-dm marked this pull request as ready for review October 12, 2023 03:10
@qizichao-dm qizichao-dm requested a review from a team as a code owner October 12, 2023 03:10
Signed-off-by: Zichao Qi <qizichao@deepmirror.com>
Signed-off-by: Zichao Qi <qizichao@deepmirror.com>
@zroubalik
Copy link
Member

zroubalik commented Oct 12, 2023

/run-e2e pulsar
Update: You can check the progress here

@zroubalik zroubalik merged commit 7601743 into kedacore:main Oct 13, 2023
19 checks passed
@qizichao-dm
Copy link
Contributor Author

@zroubalik Will this change be cherry-picked to 2.12? From the roadmap, 2.13 is next year and I want to use this feature sooner.

@zroubalik
Copy link
Member

@qizichao-dm we usually don't backport features, just security and critical patches

toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
Signed-off-by: Zichao Qi <qizichao@deepmirror.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulsar Scaler OAuth support audience
2 participants