-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating scaledObject annotations does not propagate the to HPA #5468
Comments
Hey! |
I think that the issue is just that KEDA doesn't trigger a reconciliation if (generic) annotations or labels change: keda/controllers/keda/scaledobject_controller.go Lines 129 to 136 in cd57dd9
Do you know if there is any reason for ignoring those changes @zroubalik ? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Yeah, this has been done to reduce the number of reconciliations. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed due to inactivity. |
Report
We need some annotations on our HPA for internal process. And sometimes we need to update them.
Acutally
scaledObject
annotation are propagated on creation but they are not updated ifscaledObject
change target only annotiations.If other change append at same times no there is no problem
Expected Behavior
Even if we update only annotations on
scaledObject
hpa need to be reconcile.Actual Behavior
No change append on hpa annotations
Steps to Reproduce the Problem
scaledObject
annotations and deploy itLogs from KEDA operator
KEDA Version
2.13.0
Kubernetes Version
1.26
Platform
Other
Scaler Details
cpu,prometheus
Anything else?
No response
The text was updated successfully, but these errors were encountered: