Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve GCP Pub/Sub subscription or topic name from the target's environment #5693

Closed
Tracked by #5671
jtymes opened this issue Apr 15, 2024 · 0 comments · Fixed by #5701
Closed
Tracked by #5671

Resolve GCP Pub/Sub subscription or topic name from the target's environment #5693

jtymes opened this issue Apr 15, 2024 · 0 comments · Fixed by #5701
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@jtymes
Copy link
Contributor

jtymes commented Apr 15, 2024

Proposal

The GCP Pub/Sub scaler currently allows defining the subscriptionName or the topicName. I'd like to propose adding subscriptionNameFromEnv and topicNameFromEnv. This will work similarly to the AWS SQS Scaler's queueURLFromEnv.

Use-Case

We have subscriptions that vary by region for the same workload for storing into their respective datastores. The name of the subscription is provided to the workload in each region through a ConfigMap. Using the resolved environment simplifies the ScaledObjects we need to deploy.

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant