Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new options for GCP Pub/Sub scaler #1377

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Add new options for GCP Pub/Sub scaler #1377

merged 1 commit into from
Apr 19, 2024

Conversation

jtymes
Copy link
Contributor

@jtymes jtymes commented Apr 17, 2024

Adds documentation for two new fields from kedacore/keda#5693

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1376

@jtymes
Add new options for GCP Pub/Sub scaler (kedacore#1376)
69db3ea 
Signed-off-by: Jeremy Tymes <jeremy@jtymes.net>
@jtymes jtymes requested a review from a team as a code owner April 17, 2024 10:48
@netlify Netlify
Copy link

netlify bot commented Apr 17, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 69db3ea
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/661fa917424bb200086119c2
😎 Deploy Preview https://deploy-preview-1377--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jtymes jtymes mentioned this pull request Apr 17, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@zroubalik zroubalik merged commit 5956082 into kedacore:main Apr 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation for new GCP Pub/Sub scaler options
3 participants
@jtymes @zroubalik @JorTurFer