Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing a deployment doesn't get rid of autoscale rules #80

Closed
jeffhollan opened this issue Apr 16, 2019 · 5 comments · Fixed by #81
Closed

Removing a deployment doesn't get rid of autoscale rules #80

jeffhollan opened this issue Apr 16, 2019 · 5 comments · Fixed by #81
Labels
bug Something isn't working

Comments

@jeffhollan
Copy link
Member

When I delete a deployment to Kore I still see the horizontalpodautoscaler.autoscaling resource floating around. Ideally that would be removed after I remove a deployment
@jeffhollan
Copy link
Member Author

@Aarthisk any thoughts on this?

@ahmelsayed
Copy link
Contributor

you'll need to delete the scaledObject I think. We don't track deployments, only scaled objects.

@jeffhollan
Copy link
Member Author

ah yes - fair point. Same thing may stand though. Removing the ScaledObject also doesn't seem to get rid of the autoscaling

@ahmelsayed ahmelsayed added the bug Something isn't working label Apr 16, 2019
ahmelsayed added a commit that referenced this issue Apr 16, 2019
@ahmelsayed
Call HandleScaledObjectDelete on delete
397686a 
Closes #80
@ahmelsayed ahmelsayed mentioned this issue Apr 16, 2019
Merged
@ahmelsayed
Copy link
Contributor

yep, that's definitely a bug, the controller wasn't calling deleted on the handler when a scaledObject is deleted. I opened a PR

@ahmelsayed
Copy link
Contributor

restart your kore deployment and you should get the new one.

patnaikshekhar pushed a commit to patnaikshekhar/keda that referenced this issue Jul 17, 2019
@ahmelsayed
Call HandleScaledObjectDelete on delete
f22e590 
Closes kedacore#80


Former-commit-id: 397686a
Aarthisk pushed a commit that referenced this issue Aug 12, 2019
@ahmelsayed
Call HandleScaledObjectDelete on delete
880ef77 
Closes #80


Former-commit-id: 6d344c6
preflightsiren pushed a commit to preflightsiren/keda that referenced this issue Nov 7, 2021
@ppatierno
Added default value for lag on Kafka scaler (kedacore#80)
2fc2b81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call HandleScaledObjectDelete on delete kedacore/keda
2 participants
@ahmelsayed @jeffhollan