Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid exception when CRD doesn't follow Pod spec shape #1195

Merged
merged 2 commits into from Oct 5, 2020

Conversation

anggao
Copy link
Contributor

@anggao anggao commented Sep 24, 2020

Signed-off-by: Ang Gao ang.gao87@gmail.com

Patches to avoid exception when CRD doesn't follow Pod spec shape

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1194

Signed-off-by: Ang Gao <ang.gao87@gmail.com>
pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved
Signed-off-by: Ang Gao <ang.gao87@gmail.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmelsayed ahmelsayed merged commit b391590 into kedacore:v2 Oct 5, 2020
silenceper pushed a commit to silenceper/keda that referenced this pull request Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid exception when CRD doesn't follow Pod spec shape
3 participants