Fix Memory Leak Issue of GCP PubSub #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tsuyoshi Ushio <ushio@simplearchitect.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the help of @OrenLederman , we found the root cause of the memory leak of #1257
The root cause is GCP scaler instantiate client for every
GetMetrics()call.I avoid to instantiate every time, then the big memory leak has gone.
However, there is tiny memory leak happens probably not on GCP Scaler.
I'll test by running keda several days and see if it is harmful or not with a Profiler.
Checklist
Fixes #
#1257