Disable sarama metrics and close scalers #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed ElSayed <ahmels@microsoft.com>
ahmelsayed
force-pushed
the
ahmels/mm-leak
branch
from
2a7601d
to
a712564
Compare
ycabrer
pushed a commit
to ycabrer/keda
that referenced
this pull request
Mar 1, 2021
Signed-off-by: Ahmed ElSayed <ahmels@microsoft.com>
Rodolfodc
pushed a commit
to sidilabs/keda
that referenced
this pull request
Mar 11, 2021
Signed-off-by: Ahmed ElSayed <ahmels@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed ElSayed ahmels@microsoft.com
after 500 reconciliations for a kafka ScaledObject
This IBM/sarama#1321 was the main culprit, though tbh I'm not sure what turning off those metrics affects, I verified that the kafka tests still pass. I also noticed a place where some scalers weren't being closed.
Checklist
Fixes #1565