Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt test to #381 #2051

Merged
merged 1 commit into from Aug 23, 2021
Merged

adapt test to #381 #2051

merged 1 commit into from Aug 23, 2021

Conversation

fbalicchia
Copy link
Contributor

Hi, with this pr I've adapt prometheus scaler tests input to #381

@fbalicchia
adapt test to #381
20287ea 
Signed-off-by: fbalicchia <fbalicchia@cuebiq.com>
zroubalik
zroubalik approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks :)

@zroubalik zroubalik merged commit fe032cc into kedacore:main Aug 23, 2021
@fbalicchia fbalicchia deleted the cleanup-prometheus-test branch August 23, 2021 13:05
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
@fbalicchia @nilayasiktoprak
Adapt Prometheus test to kedacore#381 (kedacore#2051)
27952d1 
Signed-off-by: fbalicchia <fbalicchia@cuebiq.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbalicchia @zroubalik