Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MongoDB dbName property parsing #2140

Merged
merged 1 commit into from Oct 4, 2021
Merged

Conversation

JorTurFer
Copy link
Member

Signed-off-by: jorturfer jorge_turrado@hotmail.es

In the context of this PR I introduced an error which has broken the e2e test. This PR solves it.
Thanks a lot @zroubalik detecting it

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer marked this pull request as ready for review October 4, 2021 15:21
@zroubalik zroubalik changed the title Fix mongdb e2e tests Fix MongoDB dbName property parsing Oct 4, 2021
@zroubalik zroubalik merged commit 526f025 into kedacore:main Oct 4, 2021
@JorTurFer JorTurFer deleted the fix_mongodb branch October 4, 2021 16:09
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants