Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta.kubernetes.io/os nodeSelector is deprecated #2280

Merged
merged 1 commit into from Nov 15, 2021

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Nov 11, 2021

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Warning: spec.template.spec.nodeSelector[beta.kubernetes.io/os]: deprecated since v1.14; use "kubernetes.io/os" instead

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik zroubalik added this to the v2.5.0 milestone Nov 11, 2021
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zroubalik zroubalik merged commit cb96564 into kedacore:main Nov 15, 2021
@tomkerkhove
Copy link
Member

@zroubalik Would you mind sending a PR to our Helm chart as well or prefer me to pick this up? If so, feel free to open a quick issue.

@zroubalik
Copy link
Member Author

@tomkerkhove I haven't found this property in charts. So it should be ok.

@tomkerkhove
Copy link
Member

Created kedacore/charts#200 since we should enforce Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants