fix: Validate TLS certificate check being disabled #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
JorTurFer
force-pushed
the
codeql_cert
branch
from
b563f84
to
6523063
Compare
|
Ignoring it on GitHub is not a problem, let's maybe just add a comment line why? |
JorTurFer
force-pushed
the
codeql_cert
branch
from
b064a60
to
af92234
Compare
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
JorTurFer
force-pushed
the
codeql_cert
branch
from
af92234
to
48adf64
Compare
tomkerkhove
approved these changes
Nov 25, 2021
zroubalik
approved these changes
Nov 25, 2021
tomkerkhove
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jorturfer jorge_turrado@hotmail.es
We need to disable the validation in those cases, so instead of ignoring it in GitHub, this could hide it
Checklist
Fixes #2336