Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Azure Queue TriggerAuthentication E2E test failure #2443

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

JatinSanghvi
Copy link
Contributor

@JatinSanghvi JatinSanghvi commented Jan 6, 2022

E2E test case in file scalers/azure-queue-trigger-auth.test.ts used to fail with below error.

Error getting triggerAuth
{
  "type": "ScaledObject",
  "namespace": "azure-queue-auth-test",
  "name": "test-scaledobject",
  "triggerAuthRef.Name": "azure-queue-auth",
  "error": "TriggerAuthentication.keda.sh \"azure-queue-auth\" not found"
}
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).buildScalers.func1
        /workspace/pkg/scaling/scale_handler.go:301
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).buildScalers
        /workspace/pkg/scaling/scale_handler.go:309
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).GetScalersCache
        /workspace/pkg/scaling/scale_handler.go:189

The reason for error must be the order of creation of resources, as the ScaledObject was being created before the TriggerAuthentication and after correcting the order, the test case started to run successfully. I could not figure out why the test case used to succeed until two months back, and what exact change caused the test to fail. Another peculiarity I found during debugging is that the test case succeeds if the KEDA operator is hosted locally (with operator SDK framework) but fails if it's hosted on the cluster.

  • Also, updated the test queue name to match with the one specified in the trigger bindings of the target Functions app.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #2268

Signed-off-by: Jatin Sanghvi <20547963+JatinSanghvi@users.noreply.github.com>
@JatinSanghvi JatinSanghvi requested a review from a team as a code owner January 6, 2022 10:24
@JatinSanghvi JatinSanghvi changed the title Fix Azure Queue TriggerAuthentication E2E test failure fix: Fix Azure Queue TriggerAuthentication E2E test failure Jan 6, 2022
@zroubalik
Copy link
Member

zroubalik commented Jan 6, 2022

/run-e2e azure-queue-trigger-auth.test*
Update: You can check the progres here

@JorTurFer
Copy link
Member

Thanks for this! ❤️

@tomkerkhove tomkerkhove merged commit 4fb7e07 into kedacore:main Jan 6, 2022
@JatinSanghvi JatinSanghvi deleted the azure-queue-e2e-test branch January 6, 2022 16:02
alex60217101990 pushed a commit to dysnix/keda that referenced this pull request Jan 10, 2022
…#2443)

Signed-off-by: alex60217101990 <alex6021710@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Queue Trigger Auth e2e test fails
4 participants