feat: Provide support for explicitly pausing autoscaling of ScaledJobs #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: keegancwinchester <keegan.winchester@shipt.com>
keegancwinchester
force-pushed
the
annotation
branch
from
5972bc2
to
0597498
Compare
JorTurFer
reviewed
Nov 17, 2022
There was a problem hiding this comment.
Hello @keegancwinchester
I have to apologize for the super slow response :(
Your PR looking good, could you open an e2e test checking that this work as expected?
| @@ -35,6 +35,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio | |||
| - [v1.2.0](#v120) | |||
| - [v1.1.0](#v110) | |||
| - [v1.0.0](#v100) | |||
| - **General:** Introduce autoscaling is paused annotation for ScaledJobs ([#3303](https://github.com/kedacore/keda/issues/3303)) | |||
There was a problem hiding this comment.
move this to new section, just above - General: Introduce new Loki Scaler
Comment on lines
+338
to
+340
| // stopScaleLoop | ||
| return r.stopScaleLoop(ctx, logger, scaledJob) | ||
| //return r.scaleHandler.DeleteScalableObject(ctx, scaledJob) |
There was a problem hiding this comment.
Can we delete these comments?
JorTurFer
changed the title
|
We are going to release KEDA v2.9 on Thursday. Do you think you can complete the open work by Wednesday @keegancwinchester? |
|
@tomkerkhove apologies for late reply. will have this done by end of week |
|
No worries at all and thank you! |
|
Any update on this? |
|
What is the current status of this PR? I thought it would be in 2.10.0 |
|
Hi @keegancwinchester |
|
When can it be expected? It would be advantageous to have this functionality. |
|
Hey, any update on this? My org is adopting Keda for it's k8s environments and this is a key piece of functionality for deploying. |
|
I'd love to get this functionality in to an upcoming release. Are you OK with others cherry-picking this MR and putting the finishing touches on @keegancwinchester's work? What would you deem the correct way to contribute to this feature? |
|
I think that this PR is abandoned :( |
flux-benj
added a commit
to flux-benj/keda
that referenced
this pull request
May 21, 2023
--- Accreditation --- Original PR: kedacore#3828 Borrows from the work originally implemented by: https://github.com/keegancwinchester Note: I would have loved to have pulled the commit from the original branch, but I could not be able to. Documentation MR by original implementor: kedacore/keda-docs#932 --- Fixes --- Fixes # kedacore#3656 --- PR Notes --- Introduce annotation to pause ScaledJobs. Signed-off-by: flux-benj <benjamin.jessop@fluxfederation.com>
7 tasks
flux-benj
added a commit
to flux-benj/keda
that referenced
this pull request
May 22, 2023
--- Accreditation --- Original PR: kedacore#3828 Borrows from the work originally implemented by: https://github.com/keegancwinchester Note: I would have loved to have pulled the commit from the original branch, but I could not be able to. Documentation MR by original implementor: kedacore/keda-docs#932 --- Fixes --- Fixes # kedacore#3656 --- PR Notes --- Introduce annotation to pause ScaledJobs. Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj
added a commit
to flux-benj/keda
that referenced
this pull request
May 23, 2023
--- Accreditation --- Original PR: kedacore#3828 Borrows from the work originally implemented by: https://github.com/keegancwinchester Note: I would have loved to have pulled the commit from the original branch, but I could not be able to. Documentation MR by original implementor: kedacore/keda-docs#932 --- Fixes --- Fixes # kedacore#3656 --- PR Notes --- Introduce annotation to pause ScaledJobs. Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj
added a commit
to flux-benj/keda
that referenced
this pull request
May 23, 2023
--- Accreditation --- Original PR: kedacore#3828 Borrows from the work originally implemented by: https://github.com/keegancwinchester Note: I would have loved to have pulled the commit from the original branch, but I could not be able to. Documentation MR by original implementor: kedacore/keda-docs#932 --- Fixes --- Fixes # kedacore#3656 --- PR Notes --- Introduce annotation to pause ScaledJobs. Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj
added a commit
to flux-benj/keda
that referenced
this pull request
Jun 11, 2023
--- Accreditation --- Original PR: kedacore#3828 Borrows from the work originally implemented by: https://github.com/keegancwinchester Note: I would have loved to have pulled the commit from the original branch, but I could not be able to. Documentation MR by original implementor: kedacore/keda-docs#932 --- Fixes --- Fixes # kedacore#3656 --- PR Notes --- Introduce annotation to pause ScaledJobs. Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj
added a commit
to flux-benj/keda
that referenced
this pull request
Jun 18, 2023
--- Accreditation --- Original PR: kedacore#3828 Borrows from the work originally implemented by: https://github.com/keegancwinchester Note: I would have loved to have pulled the commit from the original branch, but I could not be able to. Documentation MR by original implementor: kedacore/keda-docs#932 --- Fixes --- Fixes # kedacore#3656 --- PR Notes --- Introduce annotation to pause ScaledJobs. Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj
added a commit
to flux-benj/keda
that referenced
this pull request
Jun 18, 2023
--- Accreditation --- Original PR: kedacore#3828 Borrows from the work originally implemented by: https://github.com/keegancwinchester Note: I would have loved to have pulled the commit from the original branch, but I could not be able to. Documentation MR by original implementor: kedacore/keda-docs#932 --- Fixes --- Fixes # kedacore#3656 --- PR Notes --- Introduce annotation to pause ScaledJobs. Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj
added a commit
to flux-benj/keda
that referenced
this pull request
Jun 21, 2023
--- Accreditation --- Original PR: kedacore#3828 Borrows from the work originally implemented by: https://github.com/keegancwinchester Note: I would have loved to have pulled the commit from the original branch, but I could not be able to. Documentation MR by original implementor: kedacore/keda-docs#932 --- Fixes --- Fixes # kedacore#3656 --- PR Notes --- Introduce annotation to pause ScaledJobs. Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
flux-benj
added a commit
to flux-benj/keda
that referenced
this pull request
Jun 21, 2023
--- Accreditation --- Original PR: kedacore#3828 Borrows from the work originally implemented by: https://github.com/keegancwinchester Note: I would have loved to have pulled the commit from the original branch, but I could not be able to. Documentation MR by original implementor: kedacore/keda-docs#932 --- Fixes --- Fixes # kedacore#3656 --- PR Notes --- Introduce annotation to pause ScaledJobs. Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com>
zroubalik
added a commit
that referenced
this pull request
Jun 22, 2023
#4558) --- Accreditation --- Original PR: #3828 Borrows from the work originally implemented by: https://github.com/keegancwinchester Note: I would have loved to have pulled the commit from the original branch, but I could not be able to. Documentation MR by original implementor: kedacore/keda-docs#932 --- Fixes --- Fixes # #3656 --- PR Notes --- Introduce annotation to pause ScaledJobs. Signed-off-by: BenJ <benjamin.jessop@fluxfederation.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce paused annotation for scaledJobs
Checklist
Fixes #3303