fix(kafka scaler):activationLagThreshold supports 0 as valid value
#4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4137 support 0 in activationLagThreshold configuration in kafka scaler as its already supported as default value
chalokodekare
force-pushed
the
ritubhandari-fix/4137-support-0-value-in-activationLagThreshold-configuration
branch
from
2a51610
to
2f36b4e
Compare
…ivationLagThreshold-configuration
JorTurFer
approved these changes
Jan 19, 2023
|
/run-e2e kafka* |
JorTurFer
changed the title
activationLagThreshold supports 0 as valid value
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KEDA is supporting 0 as the default value for activationLagThreshold in kafka scaler. But if we set this field explicitly with the 0 value, KEDA is throwing below error:
"error":"error parsing kafka metadata: "activationLagThreshold" must be positive number"
A default should always behave the same whether you set it explicitly or leave it, if optional.
Fixed the code to accept 0 in the configuration param.
Fixes #4137