azure-pipelines scaler allows configuration of requireAllDemands #4138 #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patst
force-pushed
the
4138-azuredevops-capabilities
branch
2 times, most recently
from
ea1f829
to
baf0bce
Compare
JorTurFer
reviewed
Feb 7, 2023
|
@JorTurFer thanks for the excellent review and comments. I applied them and changed the docs PR as well |
…core#4138 Signed-off-by: Patrick Steinig <patrick.steinig@googlemail.com> Signed-off-by: patst <patrick.steinig@googlemail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: patst <patrick.steinig@googlemail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: patst <patrick.steinig@googlemail.com>
Signed-off-by: patst <patrick.steinig@googlemail.com>
patst
force-pushed
the
4138-azuredevops-capabilities
branch
from
db8b46c
to
ffaffc8
Compare
JorTurFer
approved these changes
Feb 8, 2023
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
|
/run-e2e pipeline* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Steinig patrick.steinig@googlemail.com
Introduced a new attribute for the azure-pipelines scaler named
requireAllDemandswhich only scales a if the configured capabilities of a trigger match exactly what a job demands.This allows more exact scaling, e.g. by not reacting to empty demands for jobs.
Checklist
Fixes: #4138
Relates to documentation PR kedacore/keda-docs#1063