feat(scaler): make GCP PubSub more flexible #4408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ken8203
force-pushed
the
feature/flexibler-gcp-pubsub-scaler
branch
4 times, most recently
from
a59ffaa
to
fd62c8d
Compare
1 task
ken8203
force-pushed
the
feature/flexibler-gcp-pubsub-scaler
branch
2 times, most recently
from
336b6b6
to
bf36042
Compare
Signed-off-by: Jay Chung <ken8203@gmail.com>
ken8203
force-pushed
the
feature/flexibler-gcp-pubsub-scaler
branch
from
bf36042
to
bae8177
Compare
|
I have checked the PR and I'm not 100% sure, does it introduce a breaking change? I don't think so, but just to be 100% :) |
|
/run-e2e gcp* |
JorTurFer
approved these changes
Mar 29, 2023
No, there is no breaking change here. :D |
|
Thanks for the improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the GCP PubSub scaler more flexible, simply convert the mode from camel case to snake case, e.g.
PullAckRequestCounttopull_ack_request_count, and concatenate it withpubsub.googleapis.com/subscription/, then we get the full metric name.Relates to #4243
Checklist
Ref
https://cloud.google.com/monitoring/api/metrics_gcp#gcp-pubsub