Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow convention of assert #4643

Merged
merged 1 commit into from Jun 5, 2023
Merged

Follow convention of assert #4643

merged 1 commit into from Jun 5, 2023

Conversation

yoongon
Copy link
Contributor

@yoongon yoongon commented Jun 4, 2023 •
edited

Provide a description of what has been changed

Follow convention of assert.Equal.
Expected should be go ahead before actual.

Checklist

@yoongon yoongon requested a review from a team as a code owner June 4, 2023 12:59
@yoongon yoongon force-pushed the feature/redis-testcode-convention branch from c0e2371 to 9d2f64e Compare June 4, 2023 13:02
@yoongon yoongon changed the title Follow assert order of convetion Follow convention of assert Jun 4, 2023
@yoongon
Follow convetion of assert
bdd34d7 
Signed-off-by: Yoon Park <yoongon.park@gmail.com>
@yoongon yoongon force-pushed the feature/redis-testcode-convention branch from 9d2f64e to bdd34d7 Compare June 4, 2023 13:11
zroubalik
zroubalik approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 90b200d into kedacore:main Jun 5, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoongon @zroubalik