support OAuth for pulsar scaler #4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
This was referenced Jun 19, 2023
mingmcb
force-pushed
the
feat-pulsar-oauth-extension
branch
from
91b3ccb
to
8933a45
Compare
Signed-off-by: Ming Meng <ming.meng@collibra.com>
mingmcb
force-pushed
the
feat-pulsar-oauth-extension
branch
from
8933a45
to
02c5f58
Compare
|
/run-e2e pulsar |
zroubalik
reviewed
Jun 21, 2023
There was a problem hiding this comment.
Looking great, my only concern is about exposing auth data in the trigger metadata, see: kedacore/keda-docs#1161 (review)
Signed-off-by: Ming Meng <ming.meng@collibra.com>
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
mingmcb
force-pushed
the
feat-pulsar-oauth-extension
branch
from
d8756cd
to
53b26ad
Compare
Signed-off-by: Ming Meng <101287520+mingmcb@users.noreply.github.com> Signed-off-by: Ming Meng <ming.meng@collibra.com>
mingmcb
force-pushed
the
feat-pulsar-oauth-extension
branch
from
53b26ad
to
9dca8af
Compare
|
/run-e2e pulsar |
zroubalik
requested changes
Jun 22, 2023
Signed-off-by: Ming Meng <ming.meng@collibra.com>
Signed-off-by: Ming Meng <101287520+mingmcb@users.noreply.github.com>
Signed-off-by: Ming Meng <101287520+mingmcb@users.noreply.github.com>
zroubalik
reviewed
Jul 3, 2023
mingmcb
force-pushed
the
feat-pulsar-oauth-extension
branch
2 times, most recently
from
c513f2a
to
1f5f9cb
Compare
Signed-off-by: Ming Meng <ming.meng@collibra.com>
mingmcb
force-pushed
the
feat-pulsar-oauth-extension
branch
from
1f5f9cb
to
1f809b9
Compare
|
This is great, there's also a proposal for a generic OAuth support that I like. I wonder if we can go this direction as well for Pulsar? #4694 |
|
/run-e2e pulsar |
@kedacore/keda-core-contributors WDYT? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mingmcb
force-pushed
the
feat-pulsar-oauth-extension
branch
2 times, most recently
from
3c805bf
to
c414866
Compare
zroubalik
reviewed
Sep 15, 2023
Signed-off-by: Ming Meng <ming.meng@collibra.com>
mingmcb
force-pushed
the
feat-pulsar-oauth-extension
branch
from
c414866
to
0472c41
Compare
|
/run-e2e pulsar |
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support OAuth for pulsar scaler
Checklist
Relates to #4700
Relates to kedacore/keda-docs#1161