Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Cherry-pick fixes for KEDA v2.11.1 #4744

Merged
merged 2 commits into from
Jun 29, 2023
Merged

chore: Cherry-pick fixes for KEDA v2.11.1 #4744

merged 2 commits into from
Jun 29, 2023

Conversation

tomkerkhove
Copy link
Member

Cherry-pick fixes for KEDA v2.11.1:

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #4743

@tomkerkhove tomkerkhove requested a review from a team as a code owner June 28, 2023 07:23
@tomkerkhove
Copy link
Member Author

DCO is failing because 04ca96e does not have it but I suggest to just merge as-is and favor clean fix commit over force pushing.

@JorTurFer
Copy link
Member

JorTurFer commented Jun 29, 2023 •
edited

I don't have preferences, do it as you prefer

@JorTurFer
Copy link
Member

As it's your cherry-picked commit the issue, I prefer if you amend the commit signing it

@tomkerkhove
Copy link
Member Author

tomkerkhove commented Jun 29, 2023 •
edited by JorTurFer

/run-e2e *
Update: You can check the progress here

Cancelled by @JorTurFer

@JorTurFer
Copy link
Member

JorTurFer commented Jun 29, 2023 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member

I have stopped your e2e test execution @tomkerkhove because I'm not sure if it will work. As we use golang regex, * isn't a valid regex, it should be .*
image

Just using /run-e2e execute all the suite too

@tomkerkhove tomkerkhove merged commit 62d90e8 into release/v2.11 Jun 29, 2023
19 of 20 checks passed
tomkerkhove pushed a commit that referenced this pull request Jun 29, 2023
@JorTurFer @joelsmith
chore: Cherry-pick fixes for KEDA v2.11.1 (#4744) (#4752)
b8dbd29 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Co-authored-by: Joel Smith <joelsmith@users.noreply.github.com>
@JorTurFer JorTurFer deleted the release/v2.11-fixes branch August 31, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomkerkhove @JorTurFer @Indresh2410