Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Generate standalone CRDs manifests as part of release process #4814

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

atzawada
Copy link
Contributor

Adding CRD generation to releases, so that they can be installed and managed independently of the helm chart.

Checklist

Fixes #2726

@atzawada atzawada requested a review from a team as a code owner July 20, 2023 18:30
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

Learn more about:

Signed-off-by: Andy Zawada <zawada1@nationwide.com>
Signed-off-by: Andy Zawada <zawada1@nationwide.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Nice improvement 😄

@JorTurFer JorTurFer changed the title Atzawada publish crds chore: Generate standalone CRDs manifests as part of release process Jul 20, 2023
Signed-off-by: Andy Zawada <zawada1@nationwide.com>
@atzawada
Copy link
Contributor Author

Thanks for getting back to this so quickly! And thank you for fixing the title, I think I had a bit of brain fog there. I will fix up docs PR as well

@JorTurFer
Copy link
Member

/skip-e2e

@JorTurFer JorTurFer enabled auto-merge (squash) July 26, 2023 21:44
@JorTurFer
Copy link
Member

Thanks for the contribution! ❤️

@JorTurFer JorTurFer merged commit 423fc7b into kedacore:main Jul 26, 2023
20 checks passed
yoongon pushed a commit to yoongon/keda that referenced this pull request Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate CRD manifest
3 participants