fix typo #4902
Merged
fix typo #4902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
While you are waiting, make sure to:
Learn more about: |
drmorr0
force-pushed
the
drmorr/fix-typo
branch
2 times, most recently
from
2f32dbe
to
1948f37
Compare
|
Hmmm. It doesn't seem like the failing test has anything to do with my change? Anything I can do to get it to pass? |
|
I am not quite sure why this test is failed but retry it and it will be passed. |
drmorr0
force-pushed
the
drmorr/fix-typo
branch
from
1948f37
to
e6adf32
Compare
JorTurFer
reviewed
Aug 24, 2023
drmorr0
force-pushed
the
drmorr/fix-typo
branch
from
e6adf32
to
e79387e
Compare
|
/skip-e2e |
yoongon
pushed a commit
to yoongon/keda
that referenced
this pull request
Aug 26, 2023
`s/deployment/statefulset` in `pkg/scaling/resolver/scaling_resolver.go` for the StatefulSet scaling resolver error message. Signed-off-by: David Morrison <drmorr@appliedcomputing.io> Signed-off-by: Yoon Park <yoongon.park@gmail.com>
novicr
pushed a commit
to novicr/keda
that referenced
this pull request
Aug 26, 2023
`s/deployment/statefulset` in `pkg/scaling/resolver/scaling_resolver.go` for the StatefulSet scaling resolver error message. Signed-off-by: David Morrison <drmorr@appliedcomputing.io>
Adarsh-verma-14
pushed a commit
to Adarsh-verma-14/keda
that referenced
this pull request
Sep 4, 2023
`s/deployment/statefulset` in `pkg/scaling/resolver/scaling_resolver.go` for the StatefulSet scaling resolver error message. Signed-off-by: David Morrison <drmorr@appliedcomputing.io>
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
`s/deployment/statefulset` in `pkg/scaling/resolver/scaling_resolver.go` for the StatefulSet scaling resolver error message. Signed-off-by: David Morrison <drmorr@appliedcomputing.io> Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s/deployment/statefulsetinpkg/scaling/resolver/scaling_resolver.gofor the StatefulSet scaling resolver error message.Fixed a typo in the error message for the StatefulSet scaling resolver.
Checklist
I didn't open an issue for this since it seems extremely minor. I can go back and do that if necessary.