-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka Scaler: Add UnsafeSsl flag #4911
Kafka Scaler: Add UnsafeSsl flag #4911
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
While you are waiting, make sure to:
Learn more about: |
565685a
to
6dd78cc
Compare
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
6dd78cc
to
53a0f18
Compare
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a nit in the Changelog.
@sansmoraxz FYI
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BojanZelic there's still a conflict in changelog :(
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
@zroubalik fixed |
/run-e2e kafka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Bojan Zelic <bnzelic@gmail.com> Signed-off-by: anton.lysina <alysina@gmail.com>
Adds an unsafeSsl flag for kafka autoscaler; When we want to connect to a kafka cluster (w/TLS) but the certificate is self signed or invalid (name mismatch, expired, ect..)
fixes #4977
Checklist