Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace deprecated command with environment file #4915

Merged
merged 1 commit into from Aug 28, 2023
Merged

chore: Replace deprecated command with environment file #4915

merged 1 commit into from Aug 28, 2023

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Aug 27, 2023

Description

Update workflows to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo ::set-output name=mod_cache::$(go env GOMODCACHE)
echo ::set-output name=build_cache::$(go env GOCACHE)

TO-BE

echo "mod_cache=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT
echo "build_cache=$(go env GOCACHE)" >> $GITHUB_OUTPUT

Checklist

Fixes #4914

@jongwooo jongwooo requested a review from a team as a code owner August 27, 2023 15:15
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

Learn more about:

@JorTurFer
Copy link
Member

This is nice!
Could you update the changelog as well adding the issue? 🙏
I think that Other section could be the best place

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
@JorTurFer
Copy link
Member

/skip-e2e

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this awesome contribution! 💪

@JorTurFer JorTurFer enabled auto-merge (squash) August 28, 2023 09:49
@JorTurFer JorTurFer merged commit 4218b0d into kedacore:main Aug 28, 2023
20 checks passed
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch August 28, 2023 10:20
Adarsh-verma-14 pushed a commit to Adarsh-verma-14/keda that referenced this pull request Sep 4, 2023
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
3 participants