Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce CloudEvents to KEDA #4968

Merged
merged 69 commits into from
Nov 23, 2023
Merged

feat: Introduce CloudEvents to KEDA #4968

merged 69 commits into from
Nov 23, 2023

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Sep 13, 2023 •
edited by tomkerkhove

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #3533
Relates to kedacore/keda-docs#1227
Relates to kedacore/charts#572

@SpiritZhou
Update
18d3269 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@tomkerkhove
Copy link
Member

@SpiritZhou if you have some time; would you mind opening a doc PR in parallel so that we can work on the end-user experience there?

@tomkerkhove
Copy link
Member

I'm sure this is on your radar but just in case it's not - Let's make sure to add some e2e tests. For plain HTTP, I think we can use a simple client which we can verify if the event was received and echo it back

@SpiritZhou
Copy link
Contributor Author

I'm sure this is on your radar but just in case it's not - Let's make sure to add some e2e tests. For plain HTTP, I think we can use a simple client which we can verify if the event was received and echo it back

Yes. This is a draft PR and I am adding some tests and improving coding now.

@SpiritZhou
Update
e41da36 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
79867ad 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
d1377e0 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
677765e 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
658dffa 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou mentioned this pull request Sep 19, 2023
Merged
2 tasks
@SpiritZhou
Update
2f24aff 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Merge branch 'main' into spiritzhou/cloudevent
77eda57 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Merged update
ab854e7 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
d89e24d 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
994a1e8 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
19c7c24 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou mentioned this pull request Sep 20, 2023
Merged
1 task
@SpiritZhou
Update
309a218 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
81d226c 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
b5acfb9 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou marked this pull request as ready for review September 20, 2023 08:27
@SpiritZhou SpiritZhou requested a review from a team as a code owner September 20, 2023 08:27
@SpiritZhou
Update
16e877c 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
JorTurFer
JorTurFer reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are doing an incredible work @SpiritZhou . Thanks a lot for that

CHANGELOG.md Outdated Show resolved Hide resolved
apis/keda/v1alpha1/cloudevent_types.go Outdated Show resolved Hide resolved
apis/keda/v1alpha1/cloudevent_types.go Outdated Show resolved Hide resolved
config/crd/bases/keda.sh_clustertriggerauthentications.yaml Outdated Show resolved Hide resolved
config/manager/kustomization.yaml Outdated Show resolved Hide resolved
pkg/eventemitter/eventemitter.go Outdated Show resolved Hide resolved
pkg/eventemitter/eventemitter.go Outdated Show resolved Hide resolved
pkg/eventemitter/eventemitter.go Outdated Show resolved Hide resolved
pkg/eventemitter/eventemitter.go Outdated Show resolved Hide resolved
pkg/eventemitter/eventemitter.go Outdated Show resolved Hide resolved
@SpiritZhou
Update
56fa0e7 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Fix
597105f 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
josefkarasek and others added 2 commits November 13, 2023 11:56
@josefkarasek @SpiritZhou
suggested improvements after PR review (#1)
c7f88a8 
Signed-off-by: Josef Karasek <josef@kedify.io>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
b2ccf7d 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
zroubalik
zroubalik reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a minor stuff

CHANGELOG.md Outdated Show resolved Hide resolved
pkg/eventemitter/cloudevent_http_handler.go Show resolved Hide resolved
SpiritZhou and others added 4 commits November 17, 2023 09:52
@SpiritZhou @zroubalik
Update CHANGELOG.md
03e47da 
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Add unit test
98c2808 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
145a96a 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
2048a9b 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@tomkerkhove
Copy link
Member

tomkerkhove commented Nov 17, 2023 •
edited by github-actions bot

/run-e2e cloudevent
Update: You can check the progress here

@tomkerkhove
Copy link
Member

@SpiritZhou Is the doc PR still up to date? I'll do another review pass

@tomkerkhove
Copy link
Member

tomkerkhove commented Nov 18, 2023 •
edited by github-actions bot

/run-e2e cloudevent
Update: You can check the progress here

@SpiritZhou
Copy link
Contributor Author

@SpiritZhou Is the doc PR still up to date? I'll do another review pass

The doc PR is up to date. And I see the e2e test failed at the keda installation process. How can I fix that?

zroubalik
zroubalik approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik
Copy link
Member

zroubalik commented Nov 20, 2023 •
edited by github-actions bot

/run-e2e cloudevent
Update: You can check the progress here

@zroubalik
Copy link
Member

@SpiritZhou is there a charts PR for this feature?

@tomkerkhove
Copy link
Member

To be clear - Zbynek is looking for changes on configuring the default cluster name to use in events + the new CRD to be added in the chart

@SpiritZhou SpiritZhou mentioned this pull request Nov 22, 2023
Merged
3 tasks
@SpiritZhou
Copy link
Contributor Author

@zroubalik @tomkerkhove Here is the chart PR about this feature. Could you help to review? kedacore/charts#572

@tomkerkhove
Copy link
Member

Done!

@tomkerkhove tomkerkhove changed the title Introduce CloudEvents CRD to KEDA feat: Introduce CloudEvents CRD to KEDA Nov 22, 2023
@zroubalik zroubalik changed the title feat: Introduce CloudEvents CRD to KEDA feat: Introduce CloudEvents to KEDA Nov 22, 2023
@tomkerkhove
Copy link
Member

Docs + Helm are open and depend on this one so we should be able to merge, what do you think @zroubalik?

@tomkerkhove tomkerkhove merged commit 5f741ed into kedacore:main Nov 23, 2023
19 checks passed
@zroubalik
Copy link
Member

The Charts PR is still not resolved 🤷‍♂️

yoongon pushed a commit to yoongon/keda that referenced this pull request Nov 24, 2023
@SpiritZhou @JorTurFer
@zroubalik @josefkarasek @wozniakjan @yoongon
feat: Introduce CloudEvents to KEDA (kedacore#4968)
89094c9 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Josef Karasek <karasek.jose@gmail.com>
Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: Yoon Park <yoongon.park@gmail.com>
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@SpiritZhou @JorTurFer
@zroubalik @josefkarasek @wozniakjan @toniiiik
feat: Introduce CloudEvents to KEDA (kedacore#4968)
4aa9594 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Josef Karasek <karasek.jose@gmail.com>
Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan left review comments

@josefkarasek josefkarasek josefkarasek left review comments

@semgrep-app semgrep-app[bot] semgrep-app left review comments

@zroubalik zroubalik zroubalik approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@JorTurFer JorTurFer Awaiting requested review from JorTurFer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SpiritZhou @tomkerkhove @zroubalik @wozniakjan @josefkarasek @JorTurFer