-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric Server - consolidate apiserver to one port #4982
Metric Server - consolidate apiserver to one port #4982
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
74261b7
to
2d665ab
Compare
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
This looks amazing! Thanks for the hard research that you have done ❤️ |
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
@JorTurFer added the additional e21e tests to cover both the controller-runtime and apiserver metrics |
/run-e2e prometheus |
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
…om:BojanZelic/keda into keda-metrics-consolidate-to-one-port
/run-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ❤️
Signed-off-by: Bojan Zelic <bnzelic@gmail.com> Signed-off-by: anton.lysina <alysina@gmail.com>
Provide a description of what has been changed
Checklist
Fixes #4460
Relates to kedacore/keda-docs#1225