Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo #5004

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix: typo #5004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion BUILD.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ Follow these instructions if you want to debug the KEDA webhook using VS Code.
Refer to [this](https://code.visualstudio.com/docs/editor/debugging) for more information about debugging with VS Code.
2. Expose your local instance to internet. If you can't expose it directly, you can use something like [localtunnel](https://theboroer.github.io/localtunnel-www/) using the command `lt --port 9443 --local-https --allow-invalid-cert` after installing the tool.

3. Update the `admissing_webhooks.yaml` in `config/webhooks`, replacing the section (but not commiting this change)
3. Update the `admissing_webhooks.yaml` in `config/webhooks`, replacing the section (but not committing this change)
```yaml
webhooks:
- admissionReviewVersions:
Expand Down
2 changes: 1 addition & 1 deletion hack/update-codegen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ bash "${CODEGEN_PKG}"/generate-groups.sh "client,informer,lister" \
--go-header-file "${SCRIPT_ROOT}"/hack/boilerplate.go.txt --output-base "${CODEGEN_OUTPUT_BASE}"

# (Zbynek): If v2 is specified in go.mod, codegen unfortunately outputs to 'v2/pkg/generated' instead of 'pkg/generated',
# and since we are using a specific ouput for codegen, we need to move the generated code around the repo a bit
# and since we are using a specific output for codegen, we need to move the generated code around the repo a bit
if [ -d "${CODEGEN_OUTPUT_GENERATED}" ]; then
rm -rf "${SCRIPT_ROOT}"/pkg/generated
mv "${CODEGEN_OUTPUT_GENERATED}" "${SCRIPT_ROOT}"/pkg/
Expand Down
2 changes: 1 addition & 1 deletion tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ go test -v -tags e2e ./utils/cleanup_test.go # Skip if you want to keep tes
> As default, `go test -v -tags e2e ./utils/setup_test.go` deploys KEDA from upstream's main branch,
> if you are adding an e2e test to your own code, this is not useful as you need your own version.
> Like for [building and deploying your own image](../BUILD.md#custom-keda-as-an-image), you can use
> the Makefile envrionment variables to customize KEDA deployment.
> the Makefile environment variables to customize KEDA deployment.
> eg. `IMAGE_REGISTRY=docker.io IMAGE_REPO=johndoe go test -v -tags e2e ./utils/setup_test.go`

### Specific test
Expand Down