-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcp_pubsub: fix scaled object default value (#5093) #5099
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
02a54a9
to
5f880bc
Compare
/run-e2e gcp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed this PR 🤦
Could you rebase the PR to fix the conflict?
Signed-off-by: Jim Gustavsson <jim.a.gustavsson@gmail.com>
83b28e8
to
54f8f1d
Compare
/run-e2e gcp |
Head branch was pushed to by a user without write access
Last commit has broken the DCO check. You need to sign it 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimgus could you please fix the DCO so we can go ahead and merge this?
Signed-off-by: Jim Gustavsson <jim.a.gustavsson@gmail.com>
bf4ec4d
to
63bbc08
Compare
/run-e2e gcp |
/run-e2e gcp |
…#5099) Signed-off-by: Yoon Park <yoongon.park@gmail.com>
…#5099) Signed-off-by: anton.lysina <alysina@gmail.com>
Fix that the default value of
value
is used when default value ofmode
is used for GCP pubsub scaler.Checklist
Fixes #5093
Relates to #