Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcp_pubsub: fix scaled object default value (#5093) #5099

Merged
merged 3 commits into from
Nov 21, 2023
Merged

gcp_pubsub: fix scaled object default value (#5093) #5099

merged 3 commits into from
Nov 21, 2023

Conversation

jimgus
Copy link
Contributor

@jimgus jimgus commented Oct 19, 2023 •
edited by zroubalik
Loading

Fix that the default value of value is used when default value of mode is used for GCP pubsub scaler.

Checklist

  • [N/A] When introducing a new scaler, I agree with the scaling governance policy
  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • [N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • [N/A] A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5093

Relates to #

@jimgus jimgus requested a review from a team as a code owner October 19, 2023 08:51
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@zroubalik
Copy link
Member

zroubalik commented Oct 19, 2023 •
edited by github-actions bot
Loading

/run-e2e gcp
Update: You can check the progress here

JorTurFer
JorTurFer approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this PR 🤦
Could you rebase the PR to fix the conflict?

@jimgus
gcp_pubsub: fix scaled object default value (kedacore#5093)
54f8f1d 
Signed-off-by: Jim Gustavsson <jim.a.gustavsson@gmail.com>
@zroubalik
Copy link
Member

zroubalik commented Nov 1, 2023 •
edited by github-actions bot
Loading

/run-e2e gcp
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) November 1, 2023 14:15
auto-merge was automatically disabled November 1, 2023 14:33

Head branch was pushed to by a user without write access

@JorTurFer
Copy link
Member

Last commit has broken the DCO check. You need to sign it 🙏

zroubalik
zroubalik reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimgus could you please fix the DCO so we can go ahead and merge this?

@jimgus
Fix changelog ordering
63bbc08 
Signed-off-by: Jim Gustavsson <jim.a.gustavsson@gmail.com>
@JorTurFer
Copy link
Member

JorTurFer commented Nov 21, 2023 •
edited by github-actions bot
Loading

/run-e2e gcp
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) November 21, 2023 21:25
@JorTurFer
Copy link
Member

JorTurFer commented Nov 21, 2023 •
edited by github-actions bot
Loading

/run-e2e gcp
Update: You can check the progress here

@JorTurFer JorTurFer merged commit d2999a3 into kedacore:main Nov 21, 2023
19 checks passed
yoongon pushed a commit to yoongon/keda that referenced this pull request Nov 24, 2023
@jimgus @yoongon
gcp_pubsub: fix scaled object default value (kedacore#5093) (kedacore…
76bb029 
…#5099)

Signed-off-by: Yoon Park <yoongon.park@gmail.com>
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@jimgus @toniiiik
gcp_pubsub: fix scaled object default value (kedacore#5093) (kedacore…
14481ef 
…#5099)

Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with GCP PubSub scaledObject
3 participants
@jimgus @zroubalik @JorTurFer