Add support aws secretmanager authentication #5162

geoffrey1330 · 2023-11-07T09:00:07Z

Provide a description of what has been changed

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on add docs for support aws secretmanager authentication keda-docs#1289
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4628

Relates to #

github-actions · 2023-11-07T09:00:23Z

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Our contribution guide

semgrep-app · 2023-11-07T09:01:28Z

Semgrep found 6 wrong-wrapped-error findings:

pkg/scaling/resolver/aws_secretManager_handler.go: L112, L60, L57, L54, L51, L48

Semgrep found a possible error wrong wrapped.

_{Ignore this finding from wrong-wrapped-error.}

pkg/scaling/resolver/scale_resolvers.go

geoffrey1330 · 2023-11-23T20:18:31Z

Hi @JorTurFer could you please run /run-e2e

zroubalik · 2023-11-27T10:14:10Z

/run-e2e
Update: You can check the progress here

zroubalik · 2023-11-27T10:15:04Z

unit test fail

--- FAIL: TestEnvWithRestrictSecretAccess (0.00s)
    --- FAIL: TestEnvWithRestrictSecretAccess/env_reference_secret_key (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x11fdf54]

goroutine 258 [running]:
testing.tRunner.func1.2({0x1361320, 0x2728e20})
	/usr/local/go/src/testing/testing.go:1526 +0x1c8
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1529 +0x364
panic({0x1361320, 0x2728e20})
	/usr/local/go/src/runtime/panic.go:884 +0x1f4
github.com/kedacore/keda/v2/pkg/scaling/resolver.resolveSecretValue({0x1a21570, 0x400004a090}, {0xffff8c521fe8, 0x40007827d0}, {{0x1a246b8?, 0x4000c32740?}, 0x0?}, 0x4000c82fc0, {0x156f3df, 0xb}, ...)
	/__w/keda/keda/pkg/scaling/resolver/scale_resolvers.go:467 +0xd4
github.com/kedacore/keda/v2/pkg/scaling/resolver.resolveEnv({0x1a21570, 0x400004a090}, {0xffff8c521fe8, 0x40007827d0}, {{0x1a246b8?, 0x4000c32740?}, 0x599?}, 0x40005e5080, {0x1573c35, 0xe}, ...)
	/__w/keda/keda/pkg/scaling/resolver/scale_resolvers.go:354 +0x2f4
github.com/kedacore/keda/v2/pkg/scaling/resolver.TestEnvWithRestrictSecretAccess.func1(0x4000c86820)
	/__w/keda/keda/pkg/scaling/resolver/scale_resolvers_test.go:712 +0x174
testing.tRunner(0x4000c86820, 0x4000c326c0)
	/usr/local/go/src/testing/testing.go:1576 +0x104
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1629 +0x370
FAIL	github.com/kedacore/keda/v2/pkg/scaling/resolver	0.152s

geoffrey1330 · 2023-11-27T10:17:08Z

unit test fail

--- FAIL: TestEnvWithRestrictSecretAccess (0.00s)
    --- FAIL: TestEnvWithRestrictSecretAccess/env_reference_secret_key (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x11fdf54]

goroutine 258 [running]:
testing.tRunner.func1.2({0x1361320, 0x2728e20})
	/usr/local/go/src/testing/testing.go:1526 +0x1c8
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1529 +0x364
panic({0x1361320, 0x2728e20})
	/usr/local/go/src/runtime/panic.go:884 +0x1f4
github.com/kedacore/keda/v2/pkg/scaling/resolver.resolveSecretValue({0x1a21570, 0x400004a090}, {0xffff8c521fe8, 0x40007827d0}, {{0x1a246b8?, 0x4000c32740?}, 0x0?}, 0x4000c82fc0, {0x156f3df, 0xb}, ...)
	/__w/keda/keda/pkg/scaling/resolver/scale_resolvers.go:467 +0xd4
github.com/kedacore/keda/v2/pkg/scaling/resolver.resolveEnv({0x1a21570, 0x400004a090}, {0xffff8c521fe8, 0x40007827d0}, {{0x1a246b8?, 0x4000c32740?}, 0x599?}, 0x40005e5080, {0x1573c35, 0xe}, ...)
	/__w/keda/keda/pkg/scaling/resolver/scale_resolvers.go:354 +0x2f4
github.com/kedacore/keda/v2/pkg/scaling/resolver.TestEnvWithRestrictSecretAccess.func1(0x4000c86820)
	/__w/keda/keda/pkg/scaling/resolver/scale_resolvers_test.go:712 +0x174
testing.tRunner(0x4000c86820, 0x4000c326c0)
	/usr/local/go/src/testing/testing.go:1576 +0x104
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1629 +0x370
FAIL	github.com/kedacore/keda/v2/pkg/scaling/resolver	0.152s

I will look into it.

geoffrey1330 · 2023-11-27T12:29:16Z

Hi @zroubalik could you please rerun the /run-e2e as i have a made some fix.

zroubalik · 2023-11-27T13:15:12Z

/run-e2e
Update: You can check the progress here

zm-alex · 2023-11-27T21:47:34Z

@geoffrey1330 thanks for the hardwork! looking forward for this feature to be available

JorTurFer · 2023-11-27T22:12:21Z

/run-e2e aws_secretmanager
Update: You can check the progress here

JorTurFer · 2023-11-28T12:39:52Z

/run-e2e aws_secretmanager
Update: You can check the progress here

JorTurFer · 2023-11-28T16:27:54Z

/run-e2e aws_secretmanager
Update: You can check the progress here

pkg/scaling/resolver/aws_secretManager_handler.go

JorTurFer · 2023-11-28T18:46:54Z

/run-e2e aws_secretmanager
Update: You can check the progress here

JorTurFer · 2023-11-28T22:24:42Z

/run-e2e aws_secretmanager
Update: You can check the progress here

JorTurFer · 2023-11-29T22:16:16Z

/run-e2e aws_secretmanager
Update: You can check the progress here

JorTurFer · 2023-11-29T22:41:40Z

/run-e2e aws_secretmanager
Update: You can check the progress here

JorTurFer · 2023-11-29T23:41:40Z

/run-e2e aws_secretmanager
Update: You can check the progress here

tests/secret-providers/aws_secretmanager/aws_secretmanager_test.go

JorTurFer · 2023-11-30T00:06:05Z

/run-e2e aws_secretmanager
Update: You can check the progress here

zm-alex · 2023-12-04T15:54:19Z

@JorTurFer @zroubalik Any chance you could run e2e? Thanks!

zroubalik · 2023-12-04T16:37:55Z

/run-e2e aws_secretmanager
Update: You can check the progress here

geoffrey1330 · 2023-12-05T10:36:30Z

Hi @JorTurFer @zroubalik could you please review my PR.

JorTurFer

Looking good, but you used aws-sdk-go and we are using aws-sdk-go-v2. Could you update the code to use the new SDK?
Could you also add an e2e test case (split from current) which uses podIdentity instead of credentials? The code will be almost the same, so just copying and pasting you could have the majority of the work done

apis/keda/v1alpha1/triggerauthentication_types.go

go.mod

pkg/scaling/resolver/aws_secretManager_handler.go

pkg/scaling/resolver/scale_resolvers.go

tests/secret-providers/aws_secretmanager/aws_secretmanager_test.go

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

JorTurFer · 2024-01-10T21:56:36Z

/run-e2e aws_secretmanager
Update: You can check the progress here

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

pkg/scaling/resolver/aws_secretmanager_handler_test.go

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

JorTurFer · 2024-01-11T14:25:03Z

/run-e2e aws_secretmanager
Update: You can check the progress here

JorTurFer

LGTM!
Let's wait until the documentation is ready to merge

zroubalik

Great job!

There are just a few minor nits in go imports and code comments. We can go ahead once we fix these.

go.mod

pkg/scaling/resolver/scale_resolvers.go

pkg/scaling/resolver/aws_secretmanager_handler.go

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

go.mod

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

geoffrey1330 · 2024-01-12T14:08:26Z

Hi @zroubalik I've fixed all suggested changes could you please review the PR again.

go.mod

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

zroubalik · 2024-01-12T14:15:47Z

/run-e2e aws_secretmanager
Update: You can check the progress here

zroubalik

Looking good! Great job @geoffrey1330

Once all comments in docs PR kedacore/keda-docs#1289 are resolved, we can go ahead and merge this PR.

geoffrey1330 · 2024-01-12T14:23:50Z

Looking good! Great job @geoffrey1330

Once all comments in docs PR kedacore/keda-docs#1289 are resolved, we can go ahead and merge this PR.

All suggested comment resolved.

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>

geoffrey1330 requested a review from a team as a code owner November 7, 2023 09:00

geoffrey1330 force-pushed the feat/support_aws_secretmanager_authentication branch from a25b5dd to 7e75b9b Compare November 7, 2023 10:51

geoffrey1330 changed the title ~~Feat/support aws secretmanager authentication~~ Add support aws secretmanager authentication Nov 7, 2023

github-advanced-security bot found potential problems Nov 7, 2023

View reviewed changes

pkg/scaling/resolver/scale_resolvers.go Fixed Show fixed Hide fixed

JorTurFer mentioned this pull request Nov 27, 2023

Support GCP secret manager for scaler Trigger Authentication #4831

Closed

JorTurFer reviewed Nov 28, 2023

View reviewed changes

pkg/scaling/resolver/aws_secretManager_handler.go Outdated Show resolved Hide resolved

pkg/scaling/resolver/aws_secretManager_handler.go Outdated Show resolved Hide resolved

JorTurFer reviewed Nov 29, 2023

View reviewed changes

tests/secret-providers/aws_secretmanager/aws_secretmanager_test.go Show resolved Hide resolved

JorTurFer reviewed Nov 29, 2023

View reviewed changes

tests/secret-providers/aws_secretmanager/aws_secretmanager_test.go Outdated Show resolved Hide resolved

JorTurFer reviewed Dec 8, 2023

View reviewed changes

geoffrey1330 and others added 7 commits January 10, 2024 20:01

Update CHANGELOG.md

f5d631c

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Merge branch 'main' into feat/support_aws_secretmanager_authentication

1a0863f

Update triggerauthentication_types.go

80119b6

Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Update aws_secretmanager_handler.go

8eae174

Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Update aws_secretmanager_test.go

a0e30d7

Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>

Add support for aws secret manager authentication

ef7ae28

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Add support for aws secret manager authentication

0e17801

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Add support for aws secret manager authentication

8b4af1b

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

geoffrey1330 commented Jan 11, 2024

View reviewed changes

pkg/scaling/resolver/aws_secretmanager_handler_test.go Show resolved Hide resolved

JorTurFer added 2 commits January 11, 2024 14:24

Add unit tests

7918898

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

Add unit tests

59969b0

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

JorTurFer approved these changes Jan 11, 2024

View reviewed changes

zroubalik reviewed Jan 12, 2024

View reviewed changes

geoffrey1330 added 3 commits January 12, 2024 11:13

Add support for aws secret manager authentication

0e57fd8

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Add support for aws secret manager authentication

d235635

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Add support for aws secret manager authentication

c472ce3

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

zroubalik reviewed Jan 12, 2024

View reviewed changes

go.mod Outdated Show resolved Hide resolved

go.mod Outdated Show resolved Hide resolved

geoffrey1330 added 3 commits January 12, 2024 14:32

Add support for aws secret manager authentication

540a26d

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Add support for aws secret manager authentication

cc96980

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Add support for aws secret manager authentication

7b7c4d9

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

zroubalik reviewed Jan 12, 2024

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Add support for aws secret manager authentication

8dc32d7

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

zroubalik approved these changes Jan 12, 2024

View reviewed changes

zroubalik merged commit ef23ace into kedacore:main Jan 12, 2024
19 of 21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support aws secretmanager authentication #5162

Add support aws secretmanager authentication #5162

geoffrey1330 commented Nov 7, 2023 •

edited

github-actions bot commented Nov 7, 2023

semgrep-app bot commented Nov 7, 2023

geoffrey1330 commented Nov 23, 2023

zroubalik commented Nov 27, 2023 •

edited by github-actions bot

zroubalik commented Nov 27, 2023

geoffrey1330 commented Nov 27, 2023

geoffrey1330 commented Nov 27, 2023

zroubalik commented Nov 27, 2023 •

edited by github-actions bot

zm-alex commented Nov 27, 2023

JorTurFer commented Nov 27, 2023 •

edited by github-actions bot

JorTurFer commented Nov 28, 2023 •

edited by github-actions bot

JorTurFer commented Nov 28, 2023 •

edited by github-actions bot

JorTurFer commented Nov 28, 2023 •

edited by github-actions bot

JorTurFer commented Nov 28, 2023 •

edited by github-actions bot

JorTurFer commented Nov 29, 2023 •

edited by github-actions bot

JorTurFer commented Nov 29, 2023 •

edited by github-actions bot

JorTurFer commented Nov 29, 2023 •

edited by github-actions bot

JorTurFer commented Nov 30, 2023 •

edited by github-actions bot

zm-alex commented Dec 4, 2023

zroubalik commented Dec 4, 2023 •

edited by github-actions bot

geoffrey1330 commented Dec 5, 2023

JorTurFer left a comment

JorTurFer commented Jan 10, 2024 •

edited by github-actions bot

JorTurFer commented Jan 11, 2024 •

edited by github-actions bot

JorTurFer left a comment

zroubalik left a comment

geoffrey1330 commented Jan 12, 2024

zroubalik commented Jan 12, 2024 •

edited by github-actions bot

zroubalik left a comment

geoffrey1330 commented Jan 12, 2024

Add support aws secretmanager authentication #5162

Add support aws secretmanager authentication #5162

Conversation

geoffrey1330 commented Nov 7, 2023 • edited

Checklist

github-actions bot commented Nov 7, 2023

semgrep-app bot commented Nov 7, 2023

geoffrey1330 commented Nov 23, 2023

zroubalik commented Nov 27, 2023 • edited by github-actions bot

zroubalik commented Nov 27, 2023

geoffrey1330 commented Nov 27, 2023

geoffrey1330 commented Nov 27, 2023

zroubalik commented Nov 27, 2023 • edited by github-actions bot

zm-alex commented Nov 27, 2023

JorTurFer commented Nov 27, 2023 • edited by github-actions bot

JorTurFer commented Nov 28, 2023 • edited by github-actions bot

JorTurFer commented Nov 28, 2023 • edited by github-actions bot

JorTurFer commented Nov 28, 2023 • edited by github-actions bot

JorTurFer commented Nov 28, 2023 • edited by github-actions bot

JorTurFer commented Nov 29, 2023 • edited by github-actions bot

JorTurFer commented Nov 29, 2023 • edited by github-actions bot

JorTurFer commented Nov 29, 2023 • edited by github-actions bot

JorTurFer commented Nov 30, 2023 • edited by github-actions bot

zm-alex commented Dec 4, 2023

zroubalik commented Dec 4, 2023 • edited by github-actions bot

geoffrey1330 commented Dec 5, 2023

JorTurFer left a comment

Choose a reason for hiding this comment

JorTurFer commented Jan 10, 2024 • edited by github-actions bot

JorTurFer commented Jan 11, 2024 • edited by github-actions bot

JorTurFer left a comment

Choose a reason for hiding this comment

zroubalik left a comment

Choose a reason for hiding this comment

geoffrey1330 commented Jan 12, 2024

zroubalik commented Jan 12, 2024 • edited by github-actions bot

zroubalik left a comment

Choose a reason for hiding this comment

geoffrey1330 commented Jan 12, 2024

geoffrey1330 commented Nov 7, 2023 •

edited

zroubalik commented Nov 27, 2023 •

edited by github-actions bot

zroubalik commented Nov 27, 2023 •

edited by github-actions bot

JorTurFer commented Nov 27, 2023 •

edited by github-actions bot

JorTurFer commented Nov 28, 2023 •

edited by github-actions bot

JorTurFer commented Nov 28, 2023 •

edited by github-actions bot

JorTurFer commented Nov 28, 2023 •

edited by github-actions bot

JorTurFer commented Nov 28, 2023 •

edited by github-actions bot

JorTurFer commented Nov 29, 2023 •

edited by github-actions bot

JorTurFer commented Nov 29, 2023 •

edited by github-actions bot

JorTurFer commented Nov 29, 2023 •

edited by github-actions bot

JorTurFer commented Nov 30, 2023 •

edited by github-actions bot

zroubalik commented Dec 4, 2023 •

edited by github-actions bot

JorTurFer commented Jan 10, 2024 •

edited by github-actions bot

JorTurFer commented Jan 11, 2024 •

edited by github-actions bot

zroubalik commented Jan 12, 2024 •

edited by github-actions bot