Fix operator panic when spec.hashiCorpVault.credential.serviceAccount is not set #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
|
I noticed the ci failure. Will take a look at it tmr when I have time |
zroubalik
reviewed
Nov 13, 2023
dttung2905
force-pushed
the
fix-operator-panic-triggerauth-vault-value
branch
from
8d1b4d1
to
760befb
Compare
|
/run-e2e internal |
zroubalik
approved these changes
Nov 16, 2023
|
/run-e2e internal |
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
auto-merge was automatically disabled
November 16, 2023 19:26
Head branch was pushed to by a user without write access
dttung2905
force-pushed
the
fix-operator-panic-triggerauth-vault-value
branch
from
3d7fdd1
to
0159b94
Compare
|
@zroubalik I have just rebased the PR. When you are free, could you help to run the e2e test again ? 🙏 |
|
/run-e2e internal |
yoongon
pushed a commit
to yoongon/keda
that referenced
this pull request
Nov 24, 2023
… is not set (kedacore#5180) Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg> Signed-off-by: Yoon Park <yoongon.park@gmail.com>
1 task
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
… is not set (kedacore#5180) Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg> Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR fixes the issue where the operator panics when
spec.hashiCorpVault.credential.serviceAccountis not setThere are two ways we can fix this:
spec.hashiCorpVault.credential.serviceAccount=/var/run/secrets/kubernetes.io/serviceaccount/tokenPersonally I prefer the second option. Please let me know your preference so that I can make changes to the documentation repo accordingly.
Checklist
Fixes #4964