fix: safely parse renewable field from vault response #5193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
kmdrn7
force-pushed
the
fix-panic-vault-root-token
branch
from
d675994
to
b4e1f84
Compare
|
@dttung2905 PTAL |
|
@kmdrn7 Thanks for the PR. 🙏 |
dttung2905
suggested changes
Nov 20, 2023
Signed-off-by: Andika Ahmad Ramadhan <andikahmadr@gmail.com>
Signed-off-by: Andika Ahmad Ramadhan <andikahmadr@gmail.com>
kmdrn7
force-pushed
the
fix-panic-vault-root-token
branch
from
8ef71ac
to
1ccbfdb
Compare
|
/run-e2e hashicorp_vault |
JorTurFer
approved these changes
Nov 21, 2023
|
/run-e2e hashicorp_vault |
|
/run-e2e hashicorp_vault |
yoongon
pushed a commit
to yoongon/keda
that referenced
this pull request
Nov 24, 2023
* fix: safely parse renewable field from vault response Signed-off-by: Andika Ahmad Ramadhan <andikahmadr@gmail.com> * fix: typos Signed-off-by: Andika Ahmad Ramadhan <andikahmadr@gmail.com> --------- Signed-off-by: Andika Ahmad Ramadhan <andikahmadr@gmail.com> Signed-off-by: Yoon Park <yoongon.park@gmail.com>
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
* fix: safely parse renewable field from vault response Signed-off-by: Andika Ahmad Ramadhan <andikahmadr@gmail.com> * fix: typos Signed-off-by: Andika Ahmad Ramadhan <andikahmadr@gmail.com> --------- Signed-off-by: Andika Ahmad Ramadhan <andikahmadr@gmail.com> Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where keda operator throwing panic error while using
ScaledObjectwithTriggerAuthenticationthat use hashicorp vault provider authenticated using root token.Checklist
Fixes #5192