Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scale from zero when minReplicaCount is > 0 #524

Merged
merged 1 commit into from
Jan 6, 2020
Merged

scale from zero when minReplicaCount is > 0 #524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pkg/handler/scale_deployments.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,19 @@ func (h *ScaleHandler) scaleDeployment(deployment *appsv1.Deployment, scaledObje

// Try to scale it down.
h.scaleDeploymentToZero(deployment, scaledObject)
} else if !isActive &&
scaledObject.Spec.MinReplicaCount != nil &&
*deployment.Spec.Replicas < *scaledObject.Spec.MinReplicaCount {
// there are no active triggers
// AND
// deployment replicas count is less than minimum replica count specified in ScaledObject
// Let's set deployment replicas count to correct value
*deployment.Spec.Replicas = *scaledObject.Spec.MinReplicaCount

err := h.updateDeployment(deployment)
if err == nil {
h.logger.Info("Successfully set Deployment replicas count to ScaledObject minReplicaCount", "Deployment.Namespace", deployment.GetNamespace(), "Deployment.Name", deployment.GetName(), "Deployment.Replicas", *deployment.Spec.Replicas)
}
} else if isActive {
// triggers are active, but we didn't need to scale (replica count > 0)
// Update LastActiveTime to now.
Expand Down