Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Request all ScaledObject/ScaledJob triggers in parallel #5296

Merged
merged 3 commits into from
Jan 10, 2024
Merged

feat: Request all ScaledObject/ScaledJob triggers in parallel #5296

merged 3 commits into from
Jan 10, 2024

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Dec 17, 2023 •
edited

Checklist

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5276

@JorTurFer JorTurFer requested a review from a team as a code owner December 17, 2023 16:48
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@JorTurFer
Copy link
Member Author

JorTurFer commented Dec 17, 2023 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

wozniakjan
wozniakjan reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I would just try to avoid calling kube-api in multiple goroutines triggered simultaneously (even if it's PATCH on status)

pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved
zroubalik
zroubalik reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in general. Please fix the patching issue, this is something we fixed before in the existing codebase. It can introduce conflicts and inconsistency in objects.

@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 8, 2024 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 9, 2024 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

JorTurFer and others added 3 commits January 9, 2024 19:06
@JorTurFer
feat: Request all ScaledObject/ScaledJob triggers in parallel
4df73a7 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Add a unit test to check that scalers are processed in parallelk
ebc7244 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
rebase main
b9b98c4 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 9, 2024 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 9, 2024 •
edited by github-actions bot

/run-e2e scaling_modifiers
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkg/scaling/scale_handler.go Show resolved Hide resolved
zroubalik
zroubalik approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorTurFer JorTurFer mentioned this pull request Jan 10, 2024
Open
@JorTurFer JorTurFer merged commit 1c120da into kedacore:main Jan 10, 2024
19 checks passed
@JorTurFer JorTurFer deleted the support-parallel branch January 10, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees

@wozniakjan wozniakjan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Process metric in parallel
3 participants
@JorTurFer @zroubalik @wozniakjan