Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add large lag threshold test for Kafka scalers #5361

Merged

Conversation

dttung2905
Copy link
Contributor

@dttung2905 dttung2905 commented Jan 10, 2024

Hi team,

I'm adding a new test case from my investigation here.

Checklist

Relates to #5354

@dttung2905 dttung2905 requested a review from a team as a code owner January 10, 2024 22:15
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@dttung2905 dttung2905 force-pushed the add-large-lag-threshold-kafka-scaler branch from 224472b to 443ce68 Compare January 10, 2024 22:54
CHANGELOG.md Outdated Show resolved Hide resolved
@dttung2905
Copy link
Contributor Author

btw PR Welcome Bot is failing 🤔

1s
Run actions/github-script@60a0d83039c74a4aee543508d2ffcb[1](https://github.com/kedacore/keda/actions/runs/7495198848/job/20404789645?pr=5361#step:3:1)c3799cdea
  with:
    github-token: ***
    script: await github.rest.issues.createComment({
    owner: context.repo.owner,
    repo: context.repo.repo,
    issue_number: ,
    body: 'Thank you for your contribution! 🙏 We will review your PR as soon as possible.\n\n\n While you are waiting, make sure to:\n\n\n- Add an entry in [our changelog](https://github.com/kedacore/keda/blob/main/CHANGELOG.md) in alphabetical order and link related issue\n- Update the [documentation](https://github.com/kedacore/keda-docs), if needed\n- Add unit & [e[2](https://github.com/kedacore/keda/actions/runs/7495198848/job/20404789645?pr=5361#step:3:2)e](https://github.com/kedacore/keda/blob/main/tests/README.md) tests for your changes\n- GitHub checks are passing\n- Is the DCO check failing? Here is [how you can fix DCO issues](https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what)\n\n\nLearn more about:\n- Our [contribution guide](https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md)'
  });
  
    debug: false
    user-agent: actions/github-script
    result-encoding: json
    retries: 0
    retry-exempt-status-codes: 400,401,40[3](https://github.com/kedacore/keda/actions/runs/7495198848/job/20404789645?pr=5361#step:3:3),[4](https://github.com/kedacore/keda/actions/runs/7495198848/job/20404789645?pr=5361#step:3:4)04,422
SyntaxError: Unexpected token ','
    at new AsyncFunction (<anonymous>)
Error: Unhandled error: SyntaxError: Unexpected token ','

I think probably because of this PR #5365 . Let me try to rebase from master

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
…d test case

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905 dttung2905 force-pushed the add-large-lag-threshold-kafka-scaler branch from dae1ebe to ff2f6a5 Compare January 11, 2024 22:31
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@zroubalik zroubalik changed the title Add large lag threshold kafka scaler chore: add large lag threshold test for Kafka scalers Jan 12, 2024
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit a99c79e into kedacore:main Jan 12, 2024
18 of 20 checks passed
sguruvar pushed a commit to sguruvar/keda that referenced this pull request Jan 15, 2024
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants