Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to authenticate to Azure Storage using SAS tokens #5382

Merged
merged 5 commits into from Jan 18, 2024
Merged

allow to authenticate to Azure Storage using SAS tokens #5382

merged 5 commits into from Jan 18, 2024

Conversation

dzibma
Copy link
Contributor

@dzibma dzibma commented Jan 16, 2024 •
edited

Support to use Shared Access Signature (SAS) authentication in Azure Storage Queue scaler.

Checklist

Fixes #5393

Relates to kedacore/keda-docs#1293

@dzibma
allow to authenticate to Azure Storage using SAS tokens
966769e 
Signed-off-by: Martin Dzibela <martin.dzibela@kosik.cz>
@dzibma dzibma requested a review from a team as a code owner January 16, 2024 11:05
@dzibma dzibma mentioned this pull request Jan 16, 2024
Open
1 task
@dzibma
fix err message
7acb19b 
Signed-off-by: Martin Dzibela <martin.dzibela@kosik.cz>
@dzibma
dupl linter exclude for azure_storage
55df398 
Signed-off-by: Martin Dzibela <martin.dzibela@kosik.cz>
tomkerkhove
tomkerkhove approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add an end-to-end test for this?

zroubalik
zroubalik reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please open a tracking issue for this and link it in the Changelog?
We plan to ship 2.13 tomorrow, if we are able to tackle this by then, then the Changelog entry should be fixed and move from unreleased to 2.13 section

@dzibma
update CHANGELOG.md
d456d38 
Signed-off-by: Martin Dzibela <martin.dzibela@kosik.cz>
@dzibma
Merge remote-tracking branch 'origin/main' into azstorage-sas
7951c33 
Signed-off-by: Martin Dzibela <martin.dzibela@kosik.cz>
@tomkerkhove
Copy link
Member

tomkerkhove commented Jan 18, 2024 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

zroubalik
zroubalik approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated e2e test failures

@zroubalik zroubalik merged commit cf5f2cd into kedacore:main Jan 18, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Storage Queue scaler SAS token authentication
3 participants
@dzibma @tomkerkhove @zroubalik