Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit steps to initialize go mod in building guide #5481

Merged
merged 1 commit into from Feb 29, 2024
Merged

Add explicit steps to initialize go mod in building guide #5481

merged 1 commit into from Feb 29, 2024

Conversation

junekhan
Copy link
Contributor

@junekhan junekhan commented Feb 5, 2024

Add explicit steps to initialize go mod in building guide

Fixes #5477

Relates to #

@junekhan junekhan requested a review from a team as a code owner February 5, 2024 00:29
JorTurFer
JorTurFer reviewed Feb 12, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add these commands to the makefile target (build) instead of to docs? Including it there we can ensure that they are executed always

@junekhan
Copy link
Contributor Author

@JorTurFer Yes sure!

@JorTurFer
Copy link
Member

This looks nice!
Could you fix DCO check?

@junekhan junekhan force-pushed the fix/build-guide-lack-mod-init branch 2 times, most recently from 1f87322 to 9425c73 Compare February 13, 2024 09:21
@junekhan
fix: add mod update commands to makefile
01c1008 
Signed-off-by: June Han <sorrowitsch@gmail.com>
@junekhan junekhan force-pushed the fix/build-guide-lack-mod-init branch from 9425c73 to 01c1008 Compare February 13, 2024 09:24
@zroubalik zroubalik enabled auto-merge (squash) February 29, 2024 16:07
@zroubalik zroubalik merged commit bc13a2e into kedacore:main Feb 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to build in dev container
3 participants
@junekhan @JorTurFer @zroubalik