Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cross tenant authentication azure workload identity TriggerAuthentication #5517

Merged
merged 4 commits into from Mar 4, 2024
Merged

Add support for cross tenant authentication azure workload identity TriggerAuthentication #5517

merged 4 commits into from Mar 4, 2024
+300 −64

Conversation

pauldotyu
Copy link
Contributor

@pauldotyu pauldotyu commented Feb 17, 2024 •
edited by zroubalik

Enable cross-tenant and cross-cloud authentication when using the azure-workload PodIdentityProvider within TriggerAuthentication.

Checklist

Fixes #5441

Relates to #

@pauldotyu
feat: support for cross tenant/cloud auth (kedacore#5441)
672f9eb 
Signed-off-by: Paul Yu <paul.d.yu@gmail.com>
@pauldotyu pauldotyu marked this pull request as ready for review February 17, 2024 18:16
@pauldotyu pauldotyu requested a review from a team as a code owner February 17, 2024 18:16
@JorTurFer
Copy link
Member

JorTurFer commented Feb 23, 2024 •
edited by github-actions bot

/run-e2e azure
Update: You can check the progress here

JorTurFer
JorTurFer approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution ❤️

@JorTurFer
Copy link
Member

JorTurFer commented Feb 26, 2024 •
edited

Could you solve DCO issue?
image

If you click on the link you will get an explanation about how to solve it :)

@pauldotyu
check for authorityHost override only if tenantId is also set
4845e7e 
Signed-off-by: Paul Yu <paul.d.yu@gmail.com>
@pauldotyu
Copy link
Contributor Author

Could you solve DCO issue? image

If you click on the link you will get an explanation about how to solve it :)

My bad. I keep forgetting to sign my commits 😆 It should be resolved now.

@JorTurFer
Copy link
Member

JorTurFer commented Feb 26, 2024 •
edited by github-actions bot

/run-e2e azure
Update: You can check the progress here

@tomkerkhove
Copy link
Member

tomkerkhove commented Feb 27, 2024 •
edited by github-actions bot

/run-e2e azure
Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Feb 29, 2024 •
edited by github-actions bot

/run-e2e aws
Update: You can check the progress here

@pauldotyu @JorTurFer
Update apis/keda/v1alpha1/triggerauthentication_webhook.go
5ee58c1 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Paul Yu <pauyu@microsoft.com>
@JorTurFer
Update apis/keda/v1alpha1/triggerauthentication_webhook.go
dee6e1f 
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member

JorTurFer commented Feb 29, 2024 •
edited by github-actions bot

/run-e2e aws

Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Feb 29, 2024 •
edited by github-actions bot

/run-e2e aws
Update: You can check the progress here

@tomkerkhove
Copy link
Member

Wonderful!

zroubalik
zroubalik approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 610f812 into kedacore:main Mar 4, 2024
20 checks passed
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Mar 15, 2024
@pauldotyu @JorTurFer @SpiritZhou
Add support for cross tenant authentication azure workload identity T…
1db51e3 
…riggerAuthentication (kedacore#5517)

Signed-off-by: Paul Yu <paul.d.yu@gmail.com>
Signed-off-by: Paul Yu <pauyu@microsoft.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for different tenant and/or cloud in Azure Workload Identity
4 participants
@pauldotyu @JorTurFer @tomkerkhove @zroubalik