Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Prometheus error metrics are correctly exposed #5598

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Fix: Prometheus error metrics are correctly exposed #5598

merged 2 commits into from
Mar 15, 2024

Conversation

JorTurFer
Copy link
Member

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5597

@JorTurFer
fix: error metrics are correctly exposed
480722d 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
changelog
3adb9e5 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner March 12, 2024 20:53
@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 12, 2024 •
edited by github-actions bot
Loading

/run-e2e prometheus
Update: You can check the progress here

zroubalik
zroubalik approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@JorTurFer JorTurFer merged commit 0c2c81a into kedacore:main Mar 15, 2024
21 checks passed
@JorTurFer JorTurFer deleted the fix-prometheus-metrics branch March 15, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keda_scaler_errors (and other related) metric is not increased during IsActive loop
2 participants
@JorTurFer @zroubalik