WIP: Refactor aws dynamodb scaler #5961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
dttung2905
commented
Jul 14, 2024
Comment on lines
+35
to
+36
| ExpressionAttributeNames map[string]string `keda:"name=expressionAttributeNames, order=triggerMetadata"` | ||
| ExpressionAttributeValues map[string]types.AttributeValue `keda:"name=expressionAttributeValues, order=triggerMetadata"` |
There was a problem hiding this comment.
@wozniakjan Do you have any advice on how to deal with this data type?
Currently, with this setup, keda is having these similar error when i run the unit test locally
=== RUN TestParseDynamoMetadata/no_targetValue_given
aws_dynamodb_scaler_test.go:333:
Error Trace: /home/tung/go/src/keda/pkg/scalers/aws_dynamodb_scaler_test.go:333
Error: Error "error parsing DynamoDb metadata: unable to set param \"expressionAttributeNames\" value \"{ \\\"#yr\\\" : \\\"year\\\" }\": expected format key=value, got \"{ \\\"#yr\\\" : \\\"year\\\" }\"\nunable to set param \"expressionAttributeValues\" value \"{\\\":yyyy\\\": {\\\"N\\\": \\\"1994\\\"}}\": expected format key=value, got \"{\\\":yyyy\\\": {\\\"N\\\": \\\"1994\\\"}}\"" does not contain "no targetValue given"
Test: TestParseDynamoMetadata/no_targetValue_given
I think it is expecting input value something like {yyyy=1994} instead 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Relates to #5797