Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the error if TLS config fails in Rabbitmq scaler #5964

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

semihbkgr
Copy link
Contributor

It should return the error if the TLS configuration returns an error, to prevent further nil pointer dereference on the conn variable.

@semihbkgr semihbkgr requested a review from a team as a code owner July 15, 2024 19:19
Signed-off-by: semihbkgr <buyukgungorsemih@gmail.com>
@semihbkgr semihbkgr changed the title return error if tls config fails in rabbitmq scaler Return the error if TLS config fails in Rabbitmq scaler Jul 15, 2024
@JorTurFer
Copy link
Member

JorTurFer commented Jul 22, 2024

/run-e2e rabbit
Update: You can check the progress here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! ❤️

@JorTurFer JorTurFer enabled auto-merge (squash) July 22, 2024 13:11
@JorTurFer JorTurFer merged commit bb53516 into kedacore:main Jul 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants