Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zero result return to be non-error inducing #695

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

droessmj
Copy link
Contributor

@droessmj droessmj commented Mar 20, 2020

Checklist

- [ ] A PR is opened to update the documentation on https://github.com/kedacore/keda-docs
- [ ] Tests have been added

Open to adding unit tests for the prometheus scaler, but I'm assuming that's better done as a separate dedicated work item rather than shoving it into the scope of this fix? There were tests for the scaler already, but they were just for metadata validation and not for any functionality.

Fixes #657

Signed-off-by: Michael Droessler <michael.droessler@cunamutual.com>
@ahmelsayed ahmelsayed merged commit e86fc33 into kedacore:master Mar 22, 2020
@ahmelsayed
Copy link
Contributor

Thanks @droessmj for your contribution

SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus scaler throws an error when a query returns empty
2 participants