Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Mysql and Redis sample for KEDA 2.0 #28

Closed
Ritikaa96 opened this issue Feb 23, 2021 · 6 comments · Fixed by #30
Closed

No Mysql and Redis sample for KEDA 2.0 #28

Ritikaa96 opened this issue Feb 23, 2021 · 6 comments · Fixed by #30

Comments

@Ritikaa96
Copy link
Contributor

Ritikaa96 commented Feb 23, 2021 •
edited

Redis & mysql samples given in the repository are supported by KEDA v1, but there are no updated versions of the samples.
@Ritikaa96 Ritikaa96 changed the title No Redis sample for Keda 2.0 No Mysql and Redis sample for KEDA 2.0 Feb 23, 2021
@tomkerkhove
Copy link
Member

If you are willing to send a PR, we are always open for it!

@Ritikaa96
Copy link
Contributor Author

Ritikaa96 commented Feb 23, 2021 •
edited

@tomkerkhove
I just saw Jeff has already created an issue on @turbaszek keda-example repository.
We only need to change few things in yaml according to migration document. I can suggest the changes to be done as i have recorded while trying the sample but the sample is already working well for v1 so i don't know if a whole new sample is required.

@turbaszek
Copy link
Contributor

@Ritikaa96 if you would like to update the sample I would be happy to review it. I had Jeff's issue marked as "to be done" since December 🙈

As per v1 version I can create separate branch for this sample to keep it as reference.

@Ritikaa96
Copy link
Contributor Author

@turbaszek of course, sure. I'll update the mysql and redis one, i can try the httpScaler example but i think it will be better if you change that as it's latest and undocumented on the readme. PR coming your way.

@Ritikaa96
Copy link
Contributor Author

@turbaszek @tomkerkhove Created a PR on the repo. @turbaszek PTAL

@Ritikaa96 Ritikaa96 mentioned this issue Mar 8, 2021
Merged
@Ritikaa96
Copy link
Contributor Author

Ritikaa96 commented Mar 8, 2021 •
edited

Hi @tomkerkhove , the issue has been solved in this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

moving mysql & redis samples to v2 Ritikaa96/samples
3 participants
@tomkerkhove @turbaszek @Ritikaa96