Updating sample as per KEDA v2 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmands Signed-off-by: Ritikaa96 <ritika@india.nec.com>
|
@turbaszek PTAL |
turbaszek
reviewed
Feb 26, 2021
keda/redis-hpa.yaml
Outdated
| triggers: | ||
| - type: redis | ||
| metadata: | ||
| address: REDIS_ADDRESS | ||
| addressFromEnv: REDIS_ADDRESS | ||
| listName: default | ||
| listLength: "10" |
There was a problem hiding this comment.
Suggested change
| listLength: "10" | |
| listLength: "10" | |
Let's add blank new line
There was a problem hiding this comment.
@turbaszek Do you mean adding a new line between listLength and listName? or between every metadata field? Also should we Add this line in every file in keda/ folder?
There was a problem hiding this comment.
@Ritikaa96 I mean adding new line at the end of the file
turbaszek
reviewed
Feb 26, 2021
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
|
Hi @turbaszek , added the line at the end of file. ptal |
turbaszek
reviewed
Mar 4, 2021
keda/mysql-hpa.yaml
Outdated
| query: "SELECT CEIL(COUNT(*) / 10) FROM test WHERE state='QUEUED'" | ||
|
|
There was a problem hiding this comment.
Suggested change
No white spaces. Otherwise Github still will repot no new line
turbaszek
reviewed
Mar 4, 2021
keda/redis-hpa.yaml
Outdated
| listLength: "10" | ||
|
|
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
|
PTAL @turbaszek |
turbaszek
approved these changes
Mar 8, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.) Updating scaledObjects as per KEDA v2 in : mysql-hpa.yaml, redis-hpa.yaml
2.) Updating README.md: kubectl commands
Signed-off-by: Ritikaa96 ritika@india.nec.com