prefer the new unittest.mock from the standard library #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedder
reviewed
Jun 10, 2024
| try: | ||
| from unittest import mock | ||
| except ImportError: | ||
| import mock |
There was a problem hiding this comment.
We don't support the ancient versions of Python, so I think this precaution is unnecessary (unless I'm missing something).
|
Hi,
The baseline is not explicitly documented.
So yes a plain "from unittest import mock" would be enough in modern system.
Le lun. 10 juin 2024 à 15:02, Andrey Lebedev ***@***.***> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In src/ofxstatement/tests/test_plugin.py
<#297 (comment)>:
> @@ -1,6 +1,9 @@
import unittest
-import mock
+try:
+ from unittest import mock
+except ImportError:
+ import mock
We don't support the ancient versions of Python, so I think this
precaution is unnecessary (unless I'm missing something).
—
Reply to this email directly, view it on GitHub
<#297 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB47WUELUZ2U5HZ6ABFNIWDZGWPX7AVCNFSM6AAAAABJBG5GSWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBXG4ZTOOBWGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
It is somewhat documented in pyproject.toml: Line 13 in 2250754 I think we can assume it is not running on earlier pythons (and it probably won't for a lot of other reasons) |
|
Good catch. I didn't noticed.
3.9 is plenty enough.
"mock" is fully fossilizied since 3.6
Le lun. 10 juin 2024 à 15:13, Andrey Lebedev
***@***.***> a écrit :
…
It is somewhat documented in pyproject.toml: https://github.com/kedder/ofxstatement/blob/225075416c6a4f4bd9a1dd8b802e81f88dafb40e/pyproject.toml#L13
I think we can assume it is not running on earlier pythons (and it probably won't for a lot of other reasons)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/testing-cabal/mock
mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards.