Rename extraResources to includeResources

[pradeepto]

extra has different meaning than what we are trying to convey. Should rename it to extrernal which is what I think it is. What do you guys think?

[kadel]

I agree that extra is not the right word. But external seems equally strange to me.

Would it be better to have just kubernetesResources?

[pradeepto]

But what if they are OpenShift resources?

[kadel]

hmm, good point

[surajssd]

i think we had lot of discussion on naming this thing, so please come up with a generic name that also conveys the meaning then we can go with it, otherwise IMHO extraResources conveys what it does!

[concaf]

my2c

• externalResources
• providerResources
• clusterResources
• mergeResources

[kadel]

If you want to rename it that I would go with externalResources. But it kind of sounds like it's something that is external to the application, which doesn't have to be true, as is usually part of the application.

So don't know which one is better externalResources/extraResources. I'm fine with both. For me they are both equally strange :-D

[pradeepto]

@kadel @surajssd how about `include` or `includeResources` or `import` ? Pradeepto

…

On Aug 16, 2017 2:29 PM, "Tomas Kral" ***@***.***> wrote: If you want to rename it that I would go with externalResources. But it kind of sounds like it's something that is external to the application, which doesn't have to be true, as is usually part of the application. So don't know which one is better externalResources/extraResources. I'm fine with both. For me they are both equally strange :-D — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#218 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADpe9XNYL57_DngAPUGb9CzL5dyQ9GFks5sYq9jgaJpZM4OyF3p> .

[pradeepto]

@kadel @surajssd @containscafeine We discussed this and we came to a conclusion that we will use includeResources.